]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
selftests/net: packetdrill: more xfail changes (and a correction)
authorJakub Kicinski <kuba@kernel.org>
Tue, 21 Jan 2025 14:34:23 +0000 (06:34 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 23 Jan 2025 15:07:41 +0000 (07:07 -0800)
Recent change to add more cases to XFAIL has a broken regex,
the matching needs a real regex not a glob pattern.

While at it add the cases Willem pointed out during review.

Fixes: 3030e3d57ba8 ("selftests/net: packetdrill: make tcp buf limited timing tests benign")
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250121143423.215261-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/packetdrill/ksft_runner.sh

index e15c43b7359b205408ab3a1a3834f2785a1cc172..ef8b25a606d81897898fec56171df3ee44c60e75 100755 (executable)
@@ -39,11 +39,13 @@ if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
        # xfail tests that are known flaky with dbg config, not fixable.
        # still run them for coverage (and expect 100% pass without dbg).
        declare -ar xfail_list=(
+               "tcp_eor_no-coalesce-retrans.pkt"
                "tcp_fast_recovery_prr-ss.*.pkt"
+               "tcp_slow_start_slow-start-after-win-update.pkt"
                "tcp_timestamping.*.pkt"
                "tcp_user_timeout_user-timeout-probe.pkt"
                "tcp_zerocopy_epoll_.*.pkt"
-               "tcp_tcp_info_tcp-info-*-limited.pkt"
+               "tcp_tcp_info_tcp-info-.*-limited.pkt"
        )
        readonly xfail_regex="^($(printf '%s|' "${xfail_list[@]}"))$"
        [[ "$script" =~ ${xfail_regex} ]] && failfunc=ktap_test_xfail