]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: codecs: tlv320dac33: Add default value for burst_bclkdiv
authorAlex Tran <alex.t.tran@gmail.com>
Mon, 1 Sep 2025 18:40:06 +0000 (11:40 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 8 Sep 2025 15:33:31 +0000 (16:33 +0100)
Add default value for field burst_bclkdiv as initializing it to 0
is incorrect, potentially leading to a divide by 0 issue.
Valid range is 2-17 per TI datasheet. 8 was chosen as a
dummy value.

Reference <https://www.ti.com/lit/ds/symlink/tlv320dac32.pdf>.

Signed-off-by: Alex Tran <alex.t.tran@gmail.com>
Message-ID: <20250901184008.1249535-1-alex.t.tran@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tlv320dac33.c

index 36b3de75a3f439413afe2a161a931f3b3569baf5..feefc777c47e0bcd5f8463d07c464e017a8cb284 100644 (file)
@@ -1480,6 +1480,8 @@ static int dac33_i2c_probe(struct i2c_client *client)
 
        i2c_set_clientdata(client, dac33);
 
+       if (!dac33->burst_bclkdiv)
+               dac33->burst_bclkdiv = 8;
        if (!dac33->mode1_latency)
                dac33->mode1_latency = 10000; /* 10ms */
        dac33->irq = client->irq;