]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amdgpu/pm: fix UVD handing in amdgpu_dpm_set_powergating_by_smu()
authorAlex Deucher <alexander.deucher@amd.com>
Mon, 10 Feb 2025 23:18:29 +0000 (18:18 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 12 Feb 2025 23:13:32 +0000 (18:13 -0500)
UVD and VCN were split into separate dpm helpers in commit
ff69bba05f08 ("drm/amd/pm: add inst to dpm_set_powergating_by_smu")
as such, there is no need to include UVD in the is_vcn variable since
UVD and VCN are handled by separate dpm helpers now. Fix the check.

Fixes: ff69bba05f08 ("drm/amd/pm: add inst to dpm_set_powergating_by_smu")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3959
Link: https://lists.freedesktop.org/archives/amd-gfx/2025-February/119827.html
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Boyuan Zhang <boyuan.zhang@amd.com>
drivers/gpu/drm/amd/pm/amdgpu_dpm.c

index 6a9e26905edfc6a5381096e175b2b8084ac72d26..7a22aef6e59c38cd59cae8de661eb587a86f1294 100644 (file)
@@ -78,7 +78,7 @@ int amdgpu_dpm_set_powergating_by_smu(struct amdgpu_device *adev,
        int ret = 0;
        const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
        enum ip_power_state pwr_state = gate ? POWER_STATE_OFF : POWER_STATE_ON;
-       bool is_vcn = (block_type == AMD_IP_BLOCK_TYPE_UVD || block_type == AMD_IP_BLOCK_TYPE_VCN);
+       bool is_vcn = block_type == AMD_IP_BLOCK_TYPE_VCN;
 
        if (atomic_read(&adev->pm.pwr_state[block_type]) == pwr_state &&
                        (!is_vcn || adev->vcn.num_vcn_inst == 1)) {