]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
rtc: mxc_v2: let the core handle rtc range
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 19 May 2018 08:04:46 +0000 (10:04 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 19 May 2018 08:47:46 +0000 (10:47 +0200)
This RTC is a 32-bit second counter.

This also solves an issue where mxc_rtc_set_alarm() can return with the
lock taken.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-mxc_v2.c

index 4cc121a41fe04058b3b8387736b75448ff6c6490..24ca74ca632a041b8951c4610222060e2ad5a991 100644 (file)
@@ -165,11 +165,6 @@ static int mxc_rtc_set_time(struct device *dev, struct rtc_time *tm)
        time64_t time = rtc_tm_to_time64(tm);
        int ret;
 
-       if (time > U32_MAX) {
-               dev_err(dev, "RTC exceeded by %llus\n", time - U32_MAX);
-               return -EINVAL;
-       }
-
        ret = mxc_rtc_lock(pdata);
        if (ret)
                return ret;
@@ -248,11 +243,6 @@ static int mxc_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        if (ret)
                return ret;
 
-       if (time > U32_MAX) {
-               dev_err(dev, "Hopefully I am out of service by then :-(\n");
-               return -EINVAL;
-       }
-
        writel((u32)time, pdata->ioaddr + SRTC_LPSAR);
 
        /* clear alarm interrupt status bit */
@@ -348,6 +338,7 @@ static int mxc_rtc_probe(struct platform_device *pdev)
                return PTR_ERR(pdata->rtc);
 
        pdata->rtc->ops = &mxc_rtc_ops;
+       pdata->rtc->range_max = U32_MAX;
 
        clk_disable(pdata->clk);
        platform_set_drvdata(pdev, pdata);