mac802154: Only allow PAN controllers to process association requests

It is not very clear in the specification whether simple coordinators
are allowed or not to answer to association requests themselves. As
there is no synchronization mechanism, it is probably best to rely on
the relay feature of these coordinators and avoid processing them in
this case.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
Acked-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/linux-wpan/20231128111655.507479-4-miquel.raynal@bootlin.com

diff --git a/net/mac802154/scan.c b/net/mac802154/scan.c
index 5873da634fb4f0f6b1b998b103a17b0f9af602fb..1c0eeaa76560cdf0e533aad07fe6e555a0687f6d 100644 (file)
--- a/net/mac802154/scan.c
+++ b/net/mac802154/scan.c
@@ -781,6 +781,12 @@ int mac802154_process_association_req(struct ieee802154_sub_if_data *sdata,
                 unlikely(dest->short_addr != wpan_dev->short_addr))
                return -ENODEV;
 
+       if (wpan_dev->parent) {
+               dev_dbg(&sdata->dev->dev,
+                       "Ignoring ASSOC REQ, not the PAN coordinator\n");
+               return -ENODEV;
+       }
+
        mutex_lock(&wpan_dev->association_lock);
 
        memcpy(&assoc_req_pl, skb->data, sizeof(assoc_req_pl));