drm/i915/dp: Fix LT debug print in SDP CRC enable

The debug print for enabling SDP CRC16 is applicable only for DP2.0, but
this debug print was not within the uhbr check and was always printed.
Fix this by adding proper checks and returning.

v2: Fix typo in commit message (Ankit)

Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230808042000.3210715-1-arun.r.murthy@intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
index a263773f4d68a4564fcef94afd3108768a7e9008..4485ef4f8ec649a6a392ca5bd8307a1bd067f7a1 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
@@ -1390,11 +1390,13 @@ void intel_dp_128b132b_sdp_crc16(struct intel_dp *intel_dp,
         * Default value of bit 31 is '0' hence discarding the write
         * TODO: Corrective actions on SDP corruption yet to be defined
         */
-       if (intel_dp_is_uhbr(crtc_state))
-               /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */
-               drm_dp_dpcd_writeb(&intel_dp->aux,
-                                  DP_SDP_ERROR_DETECTION_CONFIGURATION,
-                                  DP_SDP_CRC16_128B132B_EN);
+       if (!intel_dp_is_uhbr(crtc_state))
+               return;
+
+       /* DP v2.0 SCR on SDP CRC16 for 128b/132b Link Layer */
+       drm_dp_dpcd_writeb(&intel_dp->aux,
+                          DP_SDP_ERROR_DETECTION_CONFIGURATION,
+                          DP_SDP_CRC16_128B132B_EN);
 
        lt_dbg(intel_dp, DP_PHY_DPRX, "DP2.0 SDP CRC16 for 128b/132b enabled\n");
 }