for_each_property_of_node(pins, pp) checks that pp is not NULL.
So there is no need to check it inside the loop.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
                if (!strcmp(pp->name, "name"))
                        continue;
 
-               if (pp  && (pp->length/sizeof(__be32)) >= OF_GPIO_ARGS_MIN) {
+               if (pp->length / sizeof(__be32) >= OF_GPIO_ARGS_MIN) {
                        npins++;
                } else {
                        pr_warn("Invalid st,pins in %s node\n", np->name);