]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: staging/imx: Missing assignment in imx_media_capture_device_register()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 11 Feb 2020 07:35:46 +0000 (08:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Oct 2020 11:12:35 +0000 (13:12 +0200)
[ Upstream commit ef0ed05dcef8a74178a8b480cce23a377b1de2b8 ]

There was supposed to be a "ret = " assignment here, otherwise the
error handling on the next line won't work.

Fixes: 64b5a49df486 ("[media] media: imx: Add Capture Device Interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Steve Longerbeam <slongerbeam@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/media/imx/imx-media-capture.c

index ea145bafb880a5d8ea75ada8dc95152879a182b6..8ff8843df51414c6b8653242f9cd63733a0e3f32 100644 (file)
@@ -685,7 +685,7 @@ int imx_media_capture_device_register(struct imx_media_video_dev *vdev)
        /* setup default format */
        fmt_src.pad = priv->src_sd_pad;
        fmt_src.which = V4L2_SUBDEV_FORMAT_ACTIVE;
-       v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt_src);
+       ret = v4l2_subdev_call(sd, pad, get_fmt, NULL, &fmt_src);
        if (ret) {
                v4l2_err(sd, "failed to get src_sd format\n");
                goto unreg;