]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/v3d: Annotate struct v3d_perfmon with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:32:14 +0000 (10:32 -0700)
committerChristian König <christian.koenig@amd.com>
Thu, 5 Oct 2023 09:31:33 +0000 (11:31 +0200)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct v3d_perfmon.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Emma Anholt <emma@anholt.net>
Cc: Melissa Wen <mwen@igalia.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Maíra Canal <mcanal@igalia.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230922173216.3823169-9-keescook@chromium.org
drivers/gpu/drm/v3d/v3d_drv.h

index 7f664a4b2a752156a13ef0e667b535e0b77afc8e..106454f28956b96336cd729251267ca9d6107334 100644 (file)
@@ -59,7 +59,7 @@ struct v3d_perfmon {
         * values can't be reset, but you can fake a reset by
         * destroying the perfmon and creating a new one.
         */
-       u64 values[];
+       u64 values[] __counted_by(ncounters);
 };
 
 struct v3d_dev {