qed: health reporter init deinit seq

Here we declare health reporter ops (empty for now)
and register these in qed probe and remove callbacks.

This way we get devlink attached to all kind of qed* PCI
device entities: networking or storage offload entity.

Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: Alexander Lobakin <alobakin@marvell.com>
Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
index 47d54a96cbb9e01d437e41c0ab25ca30b5f86547..8b2c72fa8c447e458e6b8b6408d2a98ee26cea23 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c
@@ -14,6 +14,36 @@ enum qed_devlink_param_id {
        QED_DEVLINK_PARAM_ID_IWARP_CMT,
 };
 
+static const struct devlink_health_reporter_ops qed_fw_fatal_reporter_ops = {
+               .name = "fw_fatal",
+};
+
+#define QED_REPORTER_FW_GRACEFUL_PERIOD 1200000
+
+void qed_fw_reporters_create(struct devlink *devlink)
+{
+       struct qed_devlink *dl = devlink_priv(devlink);
+
+       dl->fw_reporter = devlink_health_reporter_create(devlink, &qed_fw_fatal_reporter_ops,
+                                                        QED_REPORTER_FW_GRACEFUL_PERIOD, dl);
+       if (IS_ERR(dl->fw_reporter)) {
+               DP_NOTICE(dl->cdev, "Failed to create fw reporter, err = %ld\n",
+                         PTR_ERR(dl->fw_reporter));
+               dl->fw_reporter = NULL;
+       }
+}
+
+void qed_fw_reporters_destroy(struct devlink *devlink)
+{
+       struct qed_devlink *dl = devlink_priv(devlink);
+       struct devlink_health_reporter *rep;
+
+       rep = dl->fw_reporter;
+
+       if (!IS_ERR_OR_NULL(rep))
+               devlink_health_reporter_destroy(rep);
+}
+
 static int qed_dl_param_get(struct devlink *dl, u32 id,
                            struct devlink_param_gset_ctx *ctx)
 {
@@ -126,6 +156,8 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)
        devlink_params_publish(dl);
        cdev->iwarp_cmt = false;
 
+       qed_fw_reporters_create(dl);
+
        return dl;
 
 err_unregister:
@@ -142,6 +174,8 @@ void qed_devlink_unregister(struct devlink *devlink)
        if (!devlink)
                return;
 
+       qed_fw_reporters_destroy(devlink);
+
        devlink_params_unregister(devlink, qed_devlink_params,
                                  ARRAY_SIZE(qed_devlink_params));
 

diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.h b/drivers/net/ethernet/qlogic/qed/qed_devlink.h
index c79dc6bfa194251a8494130d2105f7137c5c94b7..c68ecf778826574ebcafe1b8d903494bd3b3d6d1 100644 (file)
--- a/drivers/net/ethernet/qlogic/qed/qed_devlink.h
+++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.h
@@ -12,4 +12,7 @@
 struct devlink *qed_devlink_register(struct qed_dev *cdev);
 void qed_devlink_unregister(struct devlink *devlink);
 
+void qed_fw_reporters_create(struct devlink *devlink);
+void qed_fw_reporters_destroy(struct devlink *devlink);
+
 #endif

diff --git a/include/linux/qed/qed_if.h b/include/linux/qed/qed_if.h
index d8368e1770dfe232238d01bb62ac4aa22127f5cb..30fe06fe06a000c884a060c133759a0937085c40 100644 (file)
--- a/include/linux/qed/qed_if.h
+++ b/include/linux/qed/qed_if.h
@@ -782,6 +782,7 @@ enum qed_nvm_flash_cmd {
 
 struct qed_devlink {
        struct qed_dev *cdev;
+       struct devlink_health_reporter *fw_reporter;
 };
 
 struct qed_common_cb_ops {