]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
usb: host: ohci-tmio: check return value after calling platform_get_resource()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 11 Oct 2021 13:49:20 +0000 (21:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:20 +0000 (11:36 +0100)
[ Upstream commit 9eff2b2e59fda25051ab36cd1cb5014661df657b ]

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20211011134920.118477-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/host/ohci-tmio.c

index 983a00e2988dc633d6bb00329644ac7cc4b114f8..702d78e0d903aeff4d25a3213d67bd076c7a7309 100644 (file)
@@ -196,7 +196,7 @@ static int ohci_hcd_tmio_drv_probe(struct platform_device *dev)
        if (usb_disabled())
                return -ENODEV;
 
-       if (!cell)
+       if (!cell || !regs || !config || !sram)
                return -EINVAL;
 
        if (irq < 0)