]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
igc: Change type of the 'igc_check_downshift' method
authorSasha Neftin <sasha.neftin@intel.com>
Sat, 23 Apr 2022 16:55:02 +0000 (19:55 +0300)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 10 May 2022 21:02:53 +0000 (14:02 -0700)
The 'igc_check_downshift' method always returns 0; there is no need
for a return value so change the type of this method to void.

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_phy.c
drivers/net/ethernet/intel/igc/igc_phy.h

index 2140ad1e8443844450c3fbb21bd1eab6e265d75a..53b77c969c85798c4644ff87feb9c3da69bec807 100644 (file)
@@ -141,18 +141,14 @@ void igc_power_down_phy_copper(struct igc_hw *hw)
  * igc_check_downshift - Checks whether a downshift in speed occurred
  * @hw: pointer to the HW structure
  *
- * Success returns 0, Failure returns 1
- *
  * A downshift is detected by querying the PHY link health.
  */
-s32 igc_check_downshift(struct igc_hw *hw)
+void igc_check_downshift(struct igc_hw *hw)
 {
        struct igc_phy_info *phy = &hw->phy;
 
        /* speed downshift not supported */
        phy->speed_downgraded = false;
-
-       return 0;
 }
 
 /**
index 1b031372d206694aca37005282d6f5519075251e..832a7e359f186dfa0b91aa2ae588256cf3a7acb7 100644 (file)
@@ -11,7 +11,7 @@ s32 igc_phy_hw_reset(struct igc_hw *hw);
 s32 igc_get_phy_id(struct igc_hw *hw);
 s32 igc_phy_has_link(struct igc_hw *hw, u32 iterations,
                     u32 usec_interval, bool *success);
-s32 igc_check_downshift(struct igc_hw *hw);
+void igc_check_downshift(struct igc_hw *hw);
 s32 igc_setup_copper_link(struct igc_hw *hw);
 void igc_power_up_phy_copper(struct igc_hw *hw);
 void igc_power_down_phy_copper(struct igc_hw *hw);