]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amdgpu/jpeg: Remove redundant ternary operators
authorLiao Yuanhong <liaoyuanhong@vivo.com>
Wed, 3 Sep 2025 12:03:49 +0000 (20:03 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 5 Sep 2025 20:06:29 +0000 (16:06 -0400)
For ternary operators in the form of "a ? true : false", if 'a' itself
returns a boolean result, the ternary operator can be omitted. Remove
redundant ternary operators to clean up the code.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c
drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c

index 481d1a2dbe5aaf549bf36b6c7d77597e7b71ab1b..5d86e1d846eb0033e1f12dabc167e92789373f85 100644 (file)
@@ -686,7 +686,7 @@ static int jpeg_v4_0_5_set_clockgating_state(struct amdgpu_ip_block *ip_block,
                                          enum amd_clockgating_state state)
 {
        struct amdgpu_device *adev = ip_block->adev;
-       bool enable = (state == AMD_CG_STATE_GATE) ? true : false;
+       bool enable = state == AMD_CG_STATE_GATE;
        int i;
 
        for (i = 0; i < adev->jpeg.num_jpeg_inst; ++i) {
index e0a71909252be5b6070445ef703434023e5a04a6..34c70270ea1dbcc4fabcd92f19f6d523cb0dad7e 100644 (file)
@@ -584,7 +584,7 @@ static int jpeg_v5_0_0_set_clockgating_state(struct amdgpu_ip_block *ip_block,
                                          enum amd_clockgating_state state)
 {
        struct amdgpu_device *adev = ip_block->adev;
-       bool enable = (state == AMD_CG_STATE_GATE) ? true : false;
+       bool enable = state == AMD_CG_STATE_GATE;
 
        if (enable) {
                if (!jpeg_v5_0_0_is_idle(ip_block))
index 47bde62b39099fb88e3b8d301f184039a95af5ef..baf097d2e1ac966c0093e9f3c0b8c17a7a1ed24f 100644 (file)
@@ -697,7 +697,7 @@ static int jpeg_v5_0_1_set_clockgating_state(struct amdgpu_ip_block *ip_block,
                                             enum amd_clockgating_state state)
 {
        struct amdgpu_device *adev = ip_block->adev;
-       bool enable = (state == AMD_CG_STATE_GATE) ? true : false;
+       bool enable = state == AMD_CG_STATE_GATE;
 
        int i;