]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ALSA: portman2x4: Use standard print API
authorTakashi Iwai <tiwai@suse.de>
Wed, 7 Aug 2024 13:33:51 +0000 (15:33 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 8 Aug 2024 05:47:22 +0000 (07:47 +0200)
Use the standard print API with dev_*() instead of the old house-baked
one.  It gives better information and allows dynamically control of
debug prints.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240807133452.9424-2-tiwai@suse.de
sound/drivers/portman2x4.c

index 6fd9e887002154643e0e75bd1b4546b1438ecac3..54d818d2f53dc4f1525ee094796421f208d80f1b 100644 (file)
@@ -385,9 +385,8 @@ static void portman_flush_input(struct portman *pm, unsigned char port)
                command = RXDATA1;
                break;
        default:
-               snd_printk(KERN_WARNING
-                          "portman_flush_input() Won't flush port %i\n",
-                          port);
+               dev_warn(pm->card->dev, "%s Won't flush port %i\n",
+                        __func__, port);
                return;
        }
 
@@ -712,7 +711,7 @@ static int snd_portman_probe(struct platform_device *pdev)
        err = snd_card_new(&pdev->dev, index[dev], id[dev], THIS_MODULE,
                           0, &card);
        if (err < 0) {
-               snd_printd("Cannot create card\n");
+               dev_dbg(&pdev->dev, "Cannot create card\n");
                return err;
        }
        strcpy(card->driver, DRIVER_NAME);
@@ -726,21 +725,21 @@ static int snd_portman_probe(struct platform_device *pdev)
                                            &portman_cb,   /* callbacks */
                                            pdev->id);     /* device number */
        if (pardev == NULL) {
-               snd_printd("Cannot register pardevice\n");
+               dev_dbg(card->dev, "Cannot register pardevice\n");
                err = -EIO;
                goto __err;
        }
 
        /* claim parport */
        if (parport_claim(pardev)) {
-               snd_printd("Cannot claim parport 0x%lx\n", pardev->port->base);
+               dev_dbg(card->dev, "Cannot claim parport 0x%lx\n", pardev->port->base);
                err = -EIO;
                goto free_pardev;
        }
 
        err = portman_create(card, pardev, &pm);
        if (err < 0) {
-               snd_printd("Cannot create main component\n");
+               dev_dbg(card->dev, "Cannot create main component\n");
                goto release_pardev;
        }
        card->private_data = pm;
@@ -754,7 +753,7 @@ static int snd_portman_probe(struct platform_device *pdev)
        
        err = snd_portman_rawmidi_create(card);
        if (err < 0) {
-               snd_printd("Creating Rawmidi component failed\n");
+               dev_dbg(card->dev, "Creating Rawmidi component failed\n");
                goto __err;
        }
 
@@ -768,11 +767,11 @@ static int snd_portman_probe(struct platform_device *pdev)
        /* At this point card will be usable */
        err = snd_card_register(card);
        if (err < 0) {
-               snd_printd("Cannot register card\n");
+               dev_dbg(card->dev, "Cannot register card\n");
                goto __err;
        }
 
-       snd_printk(KERN_INFO "Portman 2x4 on 0x%lx\n", p->base);
+       dev_info(card->dev, "Portman 2x4 on 0x%lx\n", p->base);
        return 0;
 
 release_pardev: