]> www.infradead.org Git - users/hch/misc.git/commitdiff
audit: remove path param from link denied function
authorRichard Guy Briggs <rgb@redhat.com>
Wed, 21 Mar 2018 08:42:20 +0000 (04:42 -0400)
committerPaul Moore <paul@paul-moore.com>
Wed, 21 Mar 2018 15:17:41 +0000 (11:17 -0400)
In commit 45b578fe4c3cade6f4ca1fc934ce199afd857edc
("audit: link denied should not directly generate PATH record")
the need for the struct path *link parameter was removed.
Remove the now useless struct path argument.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
fs/namei.c
include/linux/audit.h
kernel/audit.c

index 9cc91fb7f156541bd53243b35c2823bbf9ca1133..e3682bb72cb5d6afcde7017d05417840332e3f28 100644 (file)
@@ -945,7 +945,7 @@ static inline int may_follow_link(struct nameidata *nd)
        if (nd->flags & LOOKUP_RCU)
                return -ECHILD;
 
-       audit_log_link_denied("follow_link", &nd->stack[0].link);
+       audit_log_link_denied("follow_link");
        return -EACCES;
 }
 
@@ -1011,7 +1011,7 @@ static int may_linkat(struct path *link)
        if (safe_hardlink_source(inode) || inode_owner_or_capable(inode))
                return 0;
 
-       audit_log_link_denied("linkat", link);
+       audit_log_link_denied("linkat");
        return -EPERM;
 }
 
index af410d9fbf2da9f904bac6e8309c2b097142fea9..75d5b031e80271a8cc52bbfd49334ee291c01a16 100644 (file)
@@ -146,8 +146,7 @@ extern void             audit_log_d_path(struct audit_buffer *ab,
                                             const struct path *path);
 extern void                audit_log_key(struct audit_buffer *ab,
                                          char *key);
-extern void                audit_log_link_denied(const char *operation,
-                                                 const struct path *link);
+extern void                audit_log_link_denied(const char *operation);
 extern void                audit_log_lost(const char *message);
 
 extern int audit_log_task_context(struct audit_buffer *ab);
@@ -194,8 +193,7 @@ static inline void audit_log_d_path(struct audit_buffer *ab,
 { }
 static inline void audit_log_key(struct audit_buffer *ab, char *key)
 { }
-static inline void audit_log_link_denied(const char *string,
-                                        const struct path *link)
+static inline void audit_log_link_denied(const char *string)
 { }
 static inline int audit_log_task_context(struct audit_buffer *ab)
 {
index 3f2f143edadfa8bff37a51e9efb0140da3495a5c..e8bf8d78ac4afe2d6acf692eeac7703e15104b1b 100644 (file)
@@ -2308,9 +2308,8 @@ EXPORT_SYMBOL(audit_log_task_info);
 /**
  * audit_log_link_denied - report a link restriction denial
  * @operation: specific link operation
- * @link: the path that triggered the restriction
  */
-void audit_log_link_denied(const char *operation, const struct path *link)
+void audit_log_link_denied(const char *operation)
 {
        struct audit_buffer *ab;