]> www.infradead.org Git - users/sagi/nvme-cli.git/commitdiff
tests: Remove unneeded sleep statements
authorDennis Maisenbacher <dennis.maisenbacher@wdc.com>
Fri, 8 Nov 2024 08:10:26 +0000 (08:10 +0000)
committerDaniel Wagner <wagi@monom.org>
Tue, 10 Dec 2024 16:09:11 +0000 (17:09 +0100)
Removing sleep statements, which improves the test cases runtime.

Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
tests/nvme_attach_detach_ns_test.py
tests/nvme_create_max_ns_test.py
tests/nvme_format_test.py
tests/nvme_test.py

index a0e6129d5daf83c09dbec6fda002995482d47233..f23630087ab26b0ac8dc4a612f73b1e8b8eecf4c 100644 (file)
@@ -29,8 +29,6 @@ NVMe Namespace Management Testcase:-
     5. Delete Namespace.
 """
 
-import time
-
 from nvme_test import TestNVMe
 
 
@@ -59,7 +57,6 @@ class TestNVMeAttachDetachNSCmd(TestNVMe):
         self.setup_log_dir(self.__class__.__name__)
         self.ctrl_id = self.get_ctrl_id()
         self.delete_all_ns()
-        time.sleep(1)
 
     def tearDown(self):
         """
index 76cd4d4a103071076e95d8ea57c2bbd8c6572e7d..5cb7448e34897a5d0442741b038db1ebb0a2750f 100644 (file)
@@ -29,8 +29,6 @@ NVMe Namespace Management Testcase:-
     5. Delete all Namespaces.
 """
 
-import time
-
 from nvme_test import TestNVMe
 
 
@@ -63,7 +61,6 @@ class TestNVMeCreateMaxNS(TestNVMe):
         self.max_ns = self.get_max_ns()
         self.ctrl_id = self.get_ctrl_id()
         self.delete_all_ns()
-        time.sleep(1)
 
     def tearDown(self):
         """
index 9faf3dc87566d075f6af74171cb802adfdcece49..daf35740897a6206cbf05c7848a98df57a2c872f 100644 (file)
@@ -40,7 +40,6 @@ Namespace Format testcase :-
 import json
 import math
 import subprocess
-import time
 
 from nvme_test import TestNVMe
 
@@ -76,7 +75,6 @@ class TestNVMeFormatCmd(TestNVMe):
         self.test_log_dir = self.log_dir + "/" + self.__class__.__name__
         self.setup_log_dir(self.__class__.__name__)
         self.delete_all_ns()
-        time.sleep(1)
 
     def tearDown(self):
         """
index 0bd10f552ef82b94a4caae89338355e99956dac5..8088ee2e934d94e9685061a714e989864e345a58 100644 (file)
@@ -30,7 +30,6 @@ import shutil
 import stat
 import subprocess
 import sys
-import time
 import unittest
 
 from nvme_test_logger import TestNVMeLogger
@@ -165,14 +164,12 @@ class TestNVMe(unittest.TestCase):
                               stdout=subprocess.PIPE,
                               encoding='utf-8')
         self.assertEqual(err, 0, "ERROR : nvme reset failed")
-        time.sleep(5)
         rescan_cmd = "echo 1 > /sys/bus/pci/rescan"
         proc = subprocess.Popen(rescan_cmd,
                                 shell=True,
                                 stdout=subprocess.PIPE,
                                 stderr=subprocess.PIPE,
                                 encoding='utf-8')
-        time.sleep(5)
         self.assertEqual(proc.wait(), 0, "ERROR : pci rescan failed")
 
     def get_ctrl_id(self):
@@ -385,7 +382,6 @@ class TestNVMe(unittest.TestCase):
         """
         err = self.create_ns(nsze, ncap, flbas, dps)
         if err == 0:
-            time.sleep(2)
             id_ns_cmd = f"{self.nvme_bin} id-ns {self.ctrl} " + \
                 f"--namespace-id={str(nsid)}"
             err = subprocess.call(id_ns_cmd,
@@ -408,11 +404,9 @@ class TestNVMe(unittest.TestCase):
                               shell=True,
                               stdout=subprocess.PIPE,
                               encoding='utf-8')
-        time.sleep(5)
         if err == 0:
             # enumerate new namespace block device
             self.nvme_reset_ctrl()
-            time.sleep(5)
             # check if new namespace block device exists
             err = 0 if stat.S_ISBLK(os.stat(self.ns1).st_mode) else 1
         return err