ASoC: amd: vangogh: Check Bit Clock rate before snd_soc_dai_set_pll

Check bit clock is valid before setting it with snd_soc_dai_set_pll

Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
Link: https://lore.kernel.org/r/20230217110850.1045250-7-lucas.tanure@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/amd/vangogh/acp5x-mach.c b/sound/soc/amd/vangogh/acp5x-mach.c
index e7183d8ac3a23f5f64a6948185610034872a0165..c746605b63a1be93111a37afd546c8900ec5066f 100644 (file)
--- a/sound/soc/amd/vangogh/acp5x-mach.c
+++ b/sound/soc/amd/vangogh/acp5x-mach.c
@@ -119,13 +119,19 @@ static int acp5x_nau8821_hw_params(struct snd_pcm_substream *substream,
        struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
        struct snd_soc_card *card = rtd->card;
        struct snd_soc_dai *dai = snd_soc_card_get_codec_dai(card, ACP5X_NUVOTON_CODEC_DAI);
-       int ret;
+       int ret, bclk;
 
        ret = snd_soc_dai_set_sysclk(dai, NAU8821_CLK_FLL_BLK, 0, SND_SOC_CLOCK_IN);
        if (ret < 0)
                dev_err(card->dev, "can't set FS clock %d\n", ret);
-       ret = snd_soc_dai_set_pll(dai, 0, 0, snd_soc_params_to_bclk(params),
-                                 params_rate(params) * 256);
+
+       bclk = snd_soc_params_to_bclk(params);
+       if (bclk < 0) {
+               dev_err(dai->dev, "Fail to get BCLK rate: %d\n", bclk);
+               return bclk;
+       }
+
+       ret = snd_soc_dai_set_pll(dai, 0, 0, bclk, params_rate(params) * 256);
        if (ret < 0)
                dev_err(card->dev, "can't set FLL: %d\n", ret);