]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/amdgpu: fix gmc bo pin count leak in SRIOV
authorJingwen Chen <Jingwen.Chen2@amd.com>
Tue, 14 Dec 2021 03:50:39 +0000 (11:50 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 14 Dec 2021 21:10:00 +0000 (16:10 -0500)
[Why]
gmc bo will be pinned during loading amdgpu and reset in SRIOV while
only unpinned in unload amdgpu

[How]
add amdgpu_in_reset and sriov judgement to skip pin bo

v2: fix wrong judgement

Signed-off-by: Jingwen Chen <Jingwen.Chen2@amd.com>
Reviewed-by: Horace Chen <horace.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c

index d696c4754beaf7f039517a791b0e7f03d8c913b3..ae46eb35b3d7c04e3c0c747da085d4ee259bcf09 100644 (file)
@@ -992,10 +992,14 @@ static int gmc_v10_0_gart_enable(struct amdgpu_device *adev)
                return -EINVAL;
        }
 
+       if (amdgpu_sriov_vf(adev) && amdgpu_in_reset(adev))
+               goto skip_pin_bo;
+
        r = amdgpu_gart_table_vram_pin(adev);
        if (r)
                return r;
 
+skip_pin_bo:
        r = adev->gfxhub.funcs->gart_enable(adev);
        if (r)
                return r;
index c7492db3e1898afa6f813f14742208dfd97705c8..a5471923b3f6266d0963d09d2c762c348829022c 100644 (file)
@@ -1717,10 +1717,14 @@ static int gmc_v9_0_gart_enable(struct amdgpu_device *adev)
                return -EINVAL;
        }
 
+       if (amdgpu_sriov_vf(adev) && amdgpu_in_reset(adev))
+               goto skip_pin_bo;
+
        r = amdgpu_gart_table_vram_pin(adev);
        if (r)
                return r;
 
+skip_pin_bo:
        r = adev->gfxhub.funcs->gart_enable(adev);
        if (r)
                return r;