]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: page_pool: fix warning code
authorJohannes Berg <johannes.berg@intel.com>
Fri, 5 Jul 2024 11:42:06 +0000 (13:42 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Jul 2024 03:19:18 +0000 (20:19 -0700)
WARN_ON_ONCE("string") doesn't really do what appears to
be intended, so fix that.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Fixes: 90de47f020db ("page_pool: fragment API support for 32-bit arch with 64-bit DMA")
Link: https://patch.msgid.link/20240705134221.2f4de205caa1.I28496dc0f2ced580282d1fb892048017c4491e21@changeid
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/page_pool.c

index dc52f078addebead6f2c279fdd3da3656ee8a6c1..855271a6cad247f055b94d92fd8fd6bcc464111e 100644 (file)
@@ -444,7 +444,7 @@ static bool page_pool_dma_map(struct page_pool *pool, netmem_ref netmem)
        return true;
 
 unmap_failed:
-       WARN_ON_ONCE("unexpected DMA address, please report to netdev@");
+       WARN_ONCE(1, "unexpected DMA address, please report to netdev@");
        dma_unmap_page_attrs(pool->p.dev, dma,
                             PAGE_SIZE << pool->p.order, pool->p.dma_dir,
                             DMA_ATTR_SKIP_CPU_SYNC | DMA_ATTR_WEAK_ORDERING);