]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: wm_adsp: Don't use no_free_ptr() when passing to PTR_ERR()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Mon, 28 Apr 2025 09:08:03 +0000 (10:08 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 30 Apr 2025 00:38:25 +0000 (09:38 +0900)
It's no longer necessary to no_free_ptr() an auto-freed pointer before
passing it to PTR_ERR(). This was fixed by commit
cd7eb8f83fcf ("mm/slab: make __free(kfree) accept error pointers").

Removing the no_free_ptr() avoids the spurious warning
"inconsistent IS_ERR and PTR_ERR".

Fixes: b5d057a86e20 ("ASoC: wm_adsp: Use vmemdup_user() instead of open-coding")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504270751.nR3Ngfrq-lkp@intel.com/
Link: https://patch.msgid.link/20250428090803.97909-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm_adsp.c

index a2e9f32209cfddeb3af28a2d8375646e14beb084..e822979e6a195bfb58aae8d2ee0f54cd042dbf6d 100644 (file)
@@ -419,7 +419,7 @@ static int wm_coeff_tlv_put(struct snd_kcontrol *kctl,
        void *scratch __free(kvfree) = vmemdup_user(bytes, size);
 
        if (IS_ERR(scratch))
-               return PTR_ERR(no_free_ptr(scratch));
+               return PTR_ERR(scratch);
 
        return cs_dsp_coeff_lock_and_write_ctrl(cs_ctl, 0, scratch, size);
 }