]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
Bluetooth: Add new quirks for ATS2851
authorDanil Pylaev <danstiv404@gmail.com>
Mon, 21 Oct 2024 12:22:44 +0000 (12:22 +0000)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thu, 14 Nov 2024 20:33:26 +0000 (15:33 -0500)
This adds quirks for broken extended create connection,
and write auth payload timeout.

Signed-off-by: Danil Pylaev <danstiv404@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
include/net/bluetooth/hci.h
include/net/bluetooth/hci_core.h

index bab1e3d7452a2c96edcb42fcc033c2dd8fb27211..4f64066915beb6df74ad14113d7d52611e83da82 100644 (file)
@@ -300,6 +300,20 @@ enum {
         */
        HCI_QUIRK_BROKEN_SET_RPA_TIMEOUT,
 
+       /*
+        * When this quirk is set, the HCI_OP_LE_EXT_CREATE_CONN command is
+        * disabled. This is required for the Actions Semiconductor ATS2851
+        * based controllers, which erroneously claims to support it.
+        */
+       HCI_QUIRK_BROKEN_EXT_CREATE_CONN,
+
+       /*
+        * When this quirk is set, the command WRITE_AUTH_PAYLOAD_TIMEOUT is
+        * skipped. This is required for the Actions Semiconductor ATS2851
+        * based controllers, due to a race condition in pairing process.
+        */
+       HCI_QUIRK_BROKEN_WRITE_AUTH_PAYLOAD_TIMEOUT,
+
        /* When this quirk is set, MSFT extension monitor tracking by
         * address filter is supported. Since tracking quantity of each
         * pattern is limited, this feature supports tracking multiple
index 88265d37aa72e36c0d4774c7774d8b996824f89c..94ddc868497337acc59a8b27975e913f6bab1d7d 100644 (file)
@@ -1871,8 +1871,8 @@ void hci_conn_del_sysfs(struct hci_conn *conn);
                           !test_bit(HCI_QUIRK_BROKEN_EXT_SCAN, &(dev)->quirks))
 
 /* Use ext create connection if command is supported */
-#define use_ext_conn(dev) ((dev)->commands[37] & 0x80)
-
+#define use_ext_conn(dev) (((dev)->commands[37] & 0x80) && \
+       !test_bit(HCI_QUIRK_BROKEN_EXT_CREATE_CONN, &(dev)->quirks))
 /* Extended advertising support */
 #define ext_adv_capable(dev) (((dev)->le_features[1] & HCI_LE_EXT_ADV))
 
@@ -1885,8 +1885,10 @@ void hci_conn_del_sysfs(struct hci_conn *conn);
  * C24: Mandatory if the LE Controller supports Connection State and either
  * LE Feature (LL Privacy) or LE Feature (Extended Advertising) is supported
  */
-#define use_enhanced_conn_complete(dev) (ll_privacy_capable(dev) || \
-                                        ext_adv_capable(dev))
+#define use_enhanced_conn_complete(dev) ((ll_privacy_capable(dev) || \
+                                        ext_adv_capable(dev)) && \
+                                        !test_bit(HCI_QUIRK_BROKEN_EXT_CREATE_CONN, \
+                                                &(dev)->quirks))
 
 /* Periodic advertising support */
 #define per_adv_capable(dev) (((dev)->le_features[1] & HCI_LE_PERIODIC_ADV))