]> www.infradead.org Git - users/hch/blktests.git/commitdiff
tests/srp/rc: Do not pass an empty string to dd
authorBart Van Assche <bvanassche@acm.org>
Tue, 9 Jun 2020 17:28:13 +0000 (10:28 -0700)
committerOmar Sandoval <osandov@osandov.com>
Wed, 17 Jun 2020 06:12:59 +0000 (23:12 -0700)
Instead of passing an empty string as argument to dd, do not pass any
argument when not using direct I/O.

Fixes: 577caa7d2b4a ("Fix unquoted integer shellcheck errors")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
tests/srp/rc

index 7fdea2d1dccc8b2467a3e8a5788bb5a56e1ed7ae..e19bf79aff6ea1cd3374145553bca594ca6c9d25 100755 (executable)
@@ -516,12 +516,12 @@ start_lio_srpt() {
        i=0
        for r in "${vdev_path[@]}"; do
                if [ -b "$(readlink -f "$r")" ]; then
-                       oflag=oflag=direct
+                       oflag=(oflag=direct)
                else
-                       oflag=
+                       oflag=()
                fi
                echo -n "Zero-initializing $r ... " >>"$FULL"
-               dd if=/dev/zero of="${r}" bs=1M count=$((ramdisk_size>>20)) "$oflag" >/dev/null 2>&1 || return $?
+               dd if=/dev/zero of="${r}" bs=1M count=$((ramdisk_size>>20)) "${oflag[@]}" >/dev/null 2>&1 || return $?
                echo "done" >>"$FULL"
                mkdir -p "$(mountpoint $i)" || return $?
                ((i++))