media: cedrus: fix reference leak in cedrus_start_streaming

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in cedrus_start_streaming. We should fix it.

Fixes: d5aecd289babf ("media: cedrus: Implement runtime PM")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
index 667b86dde1ee888db78c735e277d5751c9d789a0..911f607d9b092f9dcdaebfd5d76e915a760a6904 100644 (file)
--- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
@@ -479,8 +479,10 @@ static int cedrus_start_streaming(struct vb2_queue *vq, unsigned int count)
 
        if (V4L2_TYPE_IS_OUTPUT(vq->type)) {
                ret = pm_runtime_get_sync(dev->dev);
-               if (ret < 0)
+               if (ret < 0) {
+                       pm_runtime_put_noidle(dev->dev);
                        goto err_cleanup;
+               }
 
                if (dev->dec_ops[ctx->current_codec]->start) {
                        ret = dev->dec_ops[ctx->current_codec]->start(ctx);