UBIFS: fix incorrect unlocking handling

When ubifs_init_security() fails, 'ui_mutex' is incorrectly
unlocked and incorrectly restores 'i_size'. Fix this.

Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
Fixes: d7f0b70d30ff ("UBIFS: Add security.* XATTR support for the UBIFS")
Reviewed-by: Ben Shelton <ben.shelton@ni.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 0fa6c803992ea2a6d791c7eb20d128038ca20b37..5b24bc42cad9dcfb85cf2f12be654a12db97695d 100644 (file)
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -272,7 +272,7 @@ static int ubifs_create(struct inode *dir, struct dentry *dentry, umode_t mode,
 
        err = ubifs_init_security(dir, inode, &dentry->d_name);
        if (err)
-               goto out_cancel;
+               goto out_inode;
 
        mutex_lock(&dir_ui->ui_mutex);
        dir->i_size += sz_change;
@@ -292,6 +292,7 @@ out_cancel:
        dir->i_size -= sz_change;
        dir_ui->ui_size = dir->i_size;
        mutex_unlock(&dir_ui->ui_mutex);
+out_inode:
        make_bad_inode(inode);
        iput(inode);
 out_budg:
@@ -732,7 +733,7 @@ static int ubifs_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
 
        err = ubifs_init_security(dir, inode, &dentry->d_name);
        if (err)
-               goto out_cancel;
+               goto out_inode;
 
        mutex_lock(&dir_ui->ui_mutex);
        insert_inode_hash(inode);
@@ -757,6 +758,7 @@ out_cancel:
        dir_ui->ui_size = dir->i_size;
        drop_nlink(dir);
        mutex_unlock(&dir_ui->ui_mutex);
+out_inode:
        make_bad_inode(inode);
        iput(inode);
 out_budg:
@@ -816,7 +818,7 @@ static int ubifs_mknod(struct inode *dir, struct dentry *dentry,
 
        err = ubifs_init_security(dir, inode, &dentry->d_name);
        if (err)
-               goto out_cancel;
+               goto out_inode;
 
        mutex_lock(&dir_ui->ui_mutex);
        dir->i_size += sz_change;
@@ -836,6 +838,7 @@ out_cancel:
        dir->i_size -= sz_change;
        dir_ui->ui_size = dir->i_size;
        mutex_unlock(&dir_ui->ui_mutex);
+out_inode:
        make_bad_inode(inode);
        iput(inode);
 out_budg:
@@ -896,7 +899,7 @@ static int ubifs_symlink(struct inode *dir, struct dentry *dentry,
 
        err = ubifs_init_security(dir, inode, &dentry->d_name);
        if (err)
-               goto out_cancel;
+               goto out_inode;
 
        mutex_lock(&dir_ui->ui_mutex);
        dir->i_size += sz_change;