bcachefs: Add error handling for zlib_deflateInit2()

In attempt_compress(), the return value of zlib_deflateInit2() needs to be
checked. A proper implementation can be found in  pstore_compress().

Add an error check and return 0 immediately if the initialzation fails.

Fixes: 986e9842fb68 ("bcachefs: Compression levels")
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

diff --git a/fs/bcachefs/compress.c b/fs/bcachefs/compress.c
index 85fc903424928d0a8fd32e3f80d4d90d3e55c335..28ed32449913ac2599e3cdc3d40d37d384aec856 100644 (file)
--- a/fs/bcachefs/compress.c
+++ b/fs/bcachefs/compress.c
@@ -371,13 +371,14 @@ static int attempt_compress(struct bch_fs *c,
                };
 
                zlib_set_workspace(&strm, workspace);
-               zlib_deflateInit2(&strm,
+               if (zlib_deflateInit2(&strm,
                                  compression.level
                                  ? clamp_t(unsigned, compression.level,
                                            Z_BEST_SPEED, Z_BEST_COMPRESSION)
                                  : Z_DEFAULT_COMPRESSION,
                                  Z_DEFLATED, -MAX_WBITS, DEF_MEM_LEVEL,
-                                 Z_DEFAULT_STRATEGY);
+                                 Z_DEFAULT_STRATEGY) != Z_OK)
+                       return 0;
 
                if (zlib_deflate(&strm, Z_FINISH) != Z_STREAM_END)
                        return 0;