ASoC: SOF: ipc4/intel: Add missing mutex_unlock()

There was a missing mutex_unlock() in sof_ipc4_widget_free()
use_chain_dma if-branch that caused a static analysis error. The
branch should not be used in a normal working configuration and if its
used its an indication of a bad topology. Add missing mutex_unlock()
and a warning print if the if-branch is taken, and another warning
print to a symmetric place in sof_ipc4_widget_setup().

Fixes: ca5ce0caa67fa9 ("ASoC: SOF: ipc4/intel: Add support for chained DMA")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202303222050.dCw0fPCW-lkp@intel.com/
Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Link: https://lore.kernel.org/r/20230322181830.574635-1-jyri.sarha@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c
index f1e1aed94da4ec4e8d57e6a4331f1e3e5c2e7b6e..12775fcb6b54aa3a8f8e73cbdfd5ce7d7210fe46 100644 (file)
--- a/sound/soc/sof/ipc4-topology.c
+++ b/sound/soc/sof/ipc4-topology.c
@@ -1989,8 +1989,11 @@ static int sof_ipc4_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget
        case snd_soc_dapm_scheduler:
                pipeline = swidget->private;
 
-               if (pipeline->use_chain_dma)
+               if (pipeline->use_chain_dma) {
+                       dev_warn(sdev->dev, "use_chain_dma set for schduler %s",
+                                swidget->widget->name);
                        return 0;
+               }
 
                dev_dbg(sdev->dev, "pipeline: %d memory pages: %d\n", swidget->pipeline_id,
                        pipeline->mem_usage);
@@ -2145,8 +2148,12 @@ static int sof_ipc4_widget_free(struct snd_sof_dev *sdev, struct snd_sof_widget
                struct sof_ipc4_msg msg = {{ 0 }};
                u32 header;
 
-               if (pipeline->use_chain_dma)
+               if (pipeline->use_chain_dma) {
+                       dev_warn(sdev->dev, "use_chain_dma set for schduler %s",
+                                swidget->widget->name);
+                       mutex_unlock(&ipc4_data->pipeline_state_mutex);
                        return 0;
+               }
 
                header = SOF_IPC4_GLB_PIPE_INSTANCE_ID(swidget->instance_id);
                header |= SOF_IPC4_MSG_TYPE_SET(SOF_IPC4_GLB_DELETE_PIPELINE);