]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
selftests/mm: Fix unused function warning for aarch64_write_signal_pkey()
authorCatalin Marinas <catalin.marinas@arm.com>
Fri, 8 Nov 2024 11:05:49 +0000 (11:05 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Mon, 11 Nov 2024 22:46:52 +0000 (22:46 +0000)
Since commit 49f59573e9e0 ("selftests/mm: Enable pkey_sighandler_tests
on arm64"), pkey_sighandler_tests.c (which includes pkey-arm64.h via
pkey-helpers.h) ends up compiled for arm64. Since it doesn't use
aarch64_write_signal_pkey(), the compiler warns:

In file included from pkey-helpers.h:106,
                 from pkey_sighandler_tests.c:31:
pkey-arm64.h:130:13: warning: ‘aarch64_write_signal_pkey’ defined but not used [-Wunused-function]
  130 | static void aarch64_write_signal_pkey(ucontext_t *uctxt, u64 pkey)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~

Make the aarch64_write_signal_pkey() a 'static inline void' function to
avoid the compiler warning.

Fixes: f5b5ea51f78f ("selftests: mm: make protection_keys test work on arm64")
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: Joey Gouly <joey.gouly@arm.com>
Cc: Kevin Brodsky <kevin.brodsky@arm.com>
Reviewed-by: Kevin Brodsky <kevin.brodsky@arm.com>
Link: https://lore.kernel.org/r/20241108110549.1185923-1-catalin.marinas@arm.com
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
tools/testing/selftests/mm/pkey-arm64.h

index d57fbeace38f4e2b5bb585e987717f6bbdf246c5..d9d2100eafc0dadbbaaa6d7254ec5246989469ec 100644 (file)
@@ -127,7 +127,7 @@ static inline u64 get_pkey_bits(u64 reg, int pkey)
        return 0;
 }
 
-static void aarch64_write_signal_pkey(ucontext_t *uctxt, u64 pkey)
+static inline void aarch64_write_signal_pkey(ucontext_t *uctxt, u64 pkey)
 {
        struct _aarch64_ctx *ctx = GET_UC_RESV_HEAD(uctxt);
        struct poe_context *poe_ctx =