platform/x86: asus-wmi: Fix spurious rfkill on UX8406MA

The Asus Zenbook Duo (UX8406MA) has a keyboard which can be
placed on the laptop to connect it via USB, or can be removed from the
laptop to reveal a hidden secondary display in which case the keyboard
operates via Bluetooth.

When it is placed on the secondary display to connect via USB, it emits
a keypress for a wireless disable. This causes the rfkill system to be
activated disconnecting the current wifi connection, which doesn't
reflect the user's true intention.

Detect this hardware and suppress any wireless switches from the
keyboard; this keyboard does not have a wireless toggle capability so
these presses are always spurious.

Signed-off-by: Mathieu Fenniak <mathieu@fenniak.net>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240823135630.128447-1-mathieu@fenniak.net
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
index fceffe2082ec582d6c432d372de5f05cc298e9cc..ed3633c5955d9fdd308f142553cc45eef8e76923 100644 (file)
--- a/drivers/platform/x86/asus-nb-wmi.c
+++ b/drivers/platform/x86/asus-nb-wmi.c
@@ -145,6 +145,10 @@ static struct quirk_entry quirk_asus_ignore_fan = {
        .wmi_ignore_fan = true,
 };
 
+static struct quirk_entry quirk_asus_zenbook_duo_kbd = {
+       .ignore_key_wlan = true,
+};
+
 static int dmi_matched(const struct dmi_system_id *dmi)
 {
        pr_info("Identified laptop model '%s'\n", dmi->ident);
@@ -516,6 +520,15 @@ static const struct dmi_system_id asus_quirks[] = {
                },
                .driver_data = &quirk_asus_ignore_fan,
        },
+       {
+               .callback = dmi_matched,
+               .ident = "ASUS Zenbook Duo UX8406MA",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "UX8406MA"),
+               },
+               .driver_data = &quirk_asus_zenbook_duo_kbd,
+       },
        {},
 };
 
@@ -630,7 +643,12 @@ static void asus_nb_wmi_key_filter(struct asus_wmi_driver *asus_wmi, int *code,
        case 0x32: /* Volume Mute */
                if (atkbd_reports_vol_keys)
                        *code = ASUS_WMI_KEY_IGNORE;
-
+               break;
+       case 0x5D: /* Wireless console Toggle */
+       case 0x5E: /* Wireless console Enable */
+       case 0x5F: /* Wireless console Disable */
+               if (quirks->ignore_key_wlan)
+                       *code = ASUS_WMI_KEY_IGNORE;
                break;
        }
 }

diff --git a/drivers/platform/x86/asus-wmi.h b/drivers/platform/x86/asus-wmi.h
index cc30f185384723f65f383b78b0075128406fc6ae..d02f15fd3482fa3d96154c122b42d4b654127c5b 100644 (file)
--- a/drivers/platform/x86/asus-wmi.h
+++ b/drivers/platform/x86/asus-wmi.h
@@ -40,6 +40,7 @@ struct quirk_entry {
        bool wmi_force_als_set;
        bool wmi_ignore_fan;
        bool filter_i8042_e1_extended_codes;
+       bool ignore_key_wlan;
        enum asus_wmi_tablet_switch_mode tablet_switch_mode;
        int wapf;
        /*