rtlwifi: rtl8821ae: fix bool comparison in expressions

There are certain conditional expressions in rtl8821ae, where a boolean
variable is compared with true/false, in forms such as (foo == true) or
(false != bar), which does not comply with checkpatch.pl (CHECK:
BOOL_COMPARISON), according to which boolean variables should be
themselves used in the condition, rather than comparing with true/false

E.g., in drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c,
"if (rtlefuse->autoload_failflag == false)" can be replaced with
"if (!rtlefuse->autoload_failflag)"

Replace all such expressions with the bool variables appropriately

Signed-off-by: Aditya Srivastava <yashsri421@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210110121525.2407-6-yashsri421@gmail.com

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
index 372d6f8caf06ef5b68c8c8ca4982bfbc7fcc1e54..e214b9062cc10b58421c70dc73822b2099082500 100644 (file)
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c
@@ -1812,7 +1812,7 @@ static bool _rtl8821ae_phy_bb8821a_config_parafile(struct ieee80211_hw *hw)
                return false;
        }
        _rtl8821ae_phy_init_tx_power_by_rate(hw);
-       if (rtlefuse->autoload_failflag == false) {
+       if (!rtlefuse->autoload_failflag) {
                rtstatus = _rtl8821ae_phy_config_bb_with_pgheaderfile(hw,
                                                    BASEBAND_CONFIG_PHY_REG);
        }
@@ -3980,7 +3980,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
                                }
                        }
 
-                       if (tx0iqkok == false)
+                       if (!tx0iqkok)
                                break;                          /* TXK fail, Don't do RXK */
 
                        if (vdf_enable == 1) {
@@ -4090,7 +4090,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
                                                }
                                        }
 
-                                       if (tx0iqkok == false) {   /* If RX mode TXK fail, then take TXK Result */
+                                       if (!tx0iqkok) {   /* If RX mode TXK fail, then take TXK Result */
                                                tx_x0_rxk[cal] = tx_x0[cal];
                                                tx_y0_rxk[cal] = tx_y0[cal];
                                                tx0iqkok = true;
@@ -4249,7 +4249,7 @@ static void _rtl8821ae_iqk_tx(struct ieee80211_hw *hw, enum radio_path path)
                                        }
                                }
 
-                               if (tx0iqkok == false) {   /* If RX mode TXK fail, then take TXK Result */
+                               if (!tx0iqkok) {   /* If RX mode TXK fail, then take TXK Result */
                                        tx_x0_rxk[cal] = tx_x0[cal];
                                        tx_y0_rxk[cal] = tx_y0[cal];
                                        tx0iqkok = true;