]> www.infradead.org Git - users/hch/configfs.git/commitdiff
cpufreq: intel_pstate: Update asym capacity for CPUs that were offline initially
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 4 Nov 2024 18:53:53 +0000 (19:53 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 4 Nov 2024 21:51:10 +0000 (22:51 +0100)
Commit 929ebc93ccaa ("cpufreq: intel_pstate: Set asymmetric CPU
capacity on hybrid systems") overlooked a corner case in which some
CPUs may be offline to start with and brought back online later,
after the intel_pstate driver has been registered, so their asymmetric
capacity will not be set.

Address this by calling hybrid_update_capacity() in the CPU
initialization path that is executed instead of the online path
for those CPUs.

Note that this asymmetric capacity update will be skipped during
driver initialization and mode switches because hybrid_max_perf_cpu
is NULL in those cases.

Fixes: 929ebc93ccaa ("cpufreq: intel_pstate: Set asymmetric CPU capacity on hybrid systems")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/1913414.tdWV9SEqCh@rjwysocki.net
drivers/cpufreq/intel_pstate.c

index 4e816f0857f24fa6d4a8732739102655c0caaf8c..cd2ac1ba53d2a33d8d4310e76a04b2dca77e8f95 100644 (file)
@@ -2275,6 +2275,11 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)
                } else {
                        cpu->pstate.scaling = perf_ctl_scaling;
                }
+               /*
+                * If the CPU is going online for the first time and it was
+                * offline initially, asym capacity scaling needs to be updated.
+                */
+               hybrid_update_capacity(cpu);
        } else {
                cpu->pstate.scaling = perf_ctl_scaling;
                cpu->pstate.max_pstate = pstate_funcs.get_max(cpu->cpu);