]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/xe: Use devm_ioremap_wc for VRAM mapping and drop manual unmap
authorPiotr Piórkowski <piotr.piorkowski@intel.com>
Mon, 14 Jul 2025 18:48:14 +0000 (20:48 +0200)
committerLucas De Marchi <lucas.demarchi@intel.com>
Wed, 16 Jul 2025 19:06:25 +0000 (12:06 -0700)
Let's replace the manual call to ioremap_wc function with devm_ioremap_wc
function, ensuring that VRAM mappings are automatically released when
the driver is detached.
Since devm_ioremap_wc registers the mapping with the device's managed
resources, the explicit iounmap call in vram_fini is no longer needed,
so let's remove it.

Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
Suggested-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Acked-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/20250714184818.89201-2-piotr.piorkowski@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_vram.c

index e421a74fb87c66dd934065ede80da43aa3c501e3..3a4c84e9efc66791a858716eeaa566ee9c18fe41 100644 (file)
@@ -156,7 +156,8 @@ static int determine_lmem_bar_size(struct xe_device *xe)
        xe->mem.vram.dpa_base = 0;
 
        /* set up a map to the total memory area. */
-       xe->mem.vram.mapping = ioremap_wc(xe->mem.vram.io_start, xe->mem.vram.io_size);
+       xe->mem.vram.mapping = devm_ioremap_wc(&pdev->dev, xe->mem.vram.io_start,
+                                              xe->mem.vram.io_size);
 
        return 0;
 }
@@ -278,9 +279,6 @@ static void vram_fini(void *arg)
        struct xe_tile *tile;
        int id;
 
-       if (xe->mem.vram.mapping)
-               iounmap(xe->mem.vram.mapping);
-
        xe->mem.vram.mapping = NULL;
 
        for_each_tile(tile, xe, id)