usb: musb: da8xx: Switch to use dev_err_probe() helper

In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-3-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/musb/da8xx.c b/drivers/usb/musb/da8xx.c
index fd4ae2dd24e5044291d2d63a7de0f9b9d3048a0c..a4e55b0c52cffd467d7c5b4d354bcaf2c64a00e0 100644 (file)
--- a/drivers/usb/musb/da8xx.c
+++ b/drivers/usb/musb/da8xx.c
@@ -523,11 +523,9 @@ static int da8xx_probe(struct platform_device *pdev)
        }
 
        glue->phy = devm_phy_get(&pdev->dev, "usb-phy");
-       if (IS_ERR(glue->phy)) {
-               if (PTR_ERR(glue->phy) != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to get phy\n");
-               return PTR_ERR(glue->phy);
-       }
+       if (IS_ERR(glue->phy))
+               return dev_err_probe(&pdev->dev, PTR_ERR(glue->phy),
+                                    "failed to get phy\n");
 
        glue->dev                       = &pdev->dev;
        glue->clk                       = clk;