net: dpaa2-eth: don't use -ENOTSUPP error code

dpaa2_eth_setup_dpni() is called from the probe path and
dpaa2_eth_set_link_ksettings() is propagated to user space.

include/linux/errno.h says that ENOTSUPP is "Defined for the NFSv3
protocol". Conventional wisdom has it to not use it in networking
drivers. Replace it with -EOPNOTSUPP.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
index 97e1856641b4b73abbc9c2152e1b96f72c60305c..515fcd18ed7221131e9f9c6d1d43a1aa8a79bfbd 100644 (file)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
@@ -3791,7 +3791,7 @@ static int dpaa2_eth_setup_dpni(struct fsl_mc_device *ls_dev)
                dev_err(dev, "DPNI version %u.%u not supported, need >= %u.%u\n",
                        priv->dpni_ver_major, priv->dpni_ver_minor,
                        DPNI_VER_MAJOR, DPNI_VER_MINOR);
-               err = -ENOTSUPP;
+               err = -EOPNOTSUPP;
                goto close;
        }
 

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
index 32a38a03db57bacbdf00c7e1465abe1a3f6ffa04..ac3a7f2897be79a43b608aed9881fc948476c8f2 100644 (file)
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-ethtool.c
@@ -117,7 +117,7 @@ dpaa2_eth_set_link_ksettings(struct net_device *net_dev,
        struct dpaa2_eth_priv *priv = netdev_priv(net_dev);
 
        if (!dpaa2_eth_is_type_phy(priv))
-               return -ENOTSUPP;
+               return -EOPNOTSUPP;
 
        return phylink_ethtool_ksettings_set(priv->mac->phylink, link_settings);
 }