Fix segmentation fault using nvme show-regs with no device name

Add check_arg_dev() to check if a device name has been provided
and use this in show_registers to avoid the following segfault:

Segmentation fault (core dumped)

Signed-off-by: Colin Ian King <colin.king@canonical.com>

diff --git a/nvme.c b/nvme.c
index 6626ed1c221d6111e898efbec5615e49a1f5c280..8ba67de24e54ae27d3642f76e348621e4aca9a48 100644 (file)
--- a/nvme.c
+++ b/nvme.c
@@ -165,13 +165,18 @@ static void open_dev(const char *dev)
        exit(errno);
 }
 
-static void get_dev(int argc, char **argv)
+static void check_arg_dev(int argc, char **argv)
 {
        if (optind >= argc) {
                errno = EINVAL;
                perror(argv[0]);
                exit(errno);
        }
+}
+
+static void get_dev(int argc, char **argv)
+{
+       check_arg_dev(argc, argv);
        open_dev((const char *)argv[optind]);
 }
 
@@ -1263,6 +1268,8 @@ static int show_registers(int argc, char **argv)
 
        while ((opt = getopt_long(argc, (char **)argv, "", NULL,
                                        &long_index)) != -1);
+
+       check_arg_dev(argc, argv);
        devicename = basename(argv[optind]);
 
        get_registers(&bar);