]> www.infradead.org Git - users/hch/misc.git/commitdiff
usb: ucsi: stm32: Use min() to improve ucsi_stm32g0_fw_cb()
authorThorsten Blum <thorsten.blum@linux.dev>
Sat, 30 Aug 2025 11:04:20 +0000 (13:04 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Sep 2025 13:20:04 +0000 (15:20 +0200)
Use min() to improve ucsi_stm32g0_fw_cb() and avoid calculating
'end - data' twice.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20250830110426.10007-2-thorsten.blum@linux.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/ucsi_stm32g0.c

index 57ef7d83a412113ce760ad056c48f8620e896b45..838ac0185082c393660b57cca523047bea41fe28 100644 (file)
@@ -10,6 +10,7 @@
 #include <linux/firmware.h>
 #include <linux/i2c.h>
 #include <linux/interrupt.h>
+#include <linux/minmax.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/unaligned.h>
@@ -523,11 +524,7 @@ static void ucsi_stm32g0_fw_cb(const struct firmware *fw, void *context)
        data = fw->data;
        end = fw->data + fw->size;
        while (data < end) {
-               if ((end - data) < STM32G0_I2C_BL_SZ)
-                       size = end - data;
-               else
-                       size = STM32G0_I2C_BL_SZ;
-
+               size = min(end - data, STM32G0_I2C_BL_SZ);
                ret = ucsi_stm32g0_bl_write(g0->ucsi, addr, data, size);
                if (ret) {
                        dev_err(g0->dev, "Write failed %d\n", ret);