]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
usb: typec: tipd: add error log to provide firmware name and size
authorJavier Carrasco <javier.carrasco@wolfvision.net>
Thu, 6 Jun 2024 09:03:56 +0000 (11:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Jun 2024 17:30:16 +0000 (19:30 +0200)
The current error logs do not show the firmware name and size for the
tps6598x. On the other hand, this information is provided for the
tps25750. Both implementations have access to that information, and the
existing message for the tps25750 can be used for the tps6598x without
extra modifications.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240606-tps6598x_fw_update_log-v1-2-2b5b8369a0ba@wolfvision.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tipd/core.c

index 851b0d02727a19c28cd912f98cf8ca27b54c7917..58f6eeffd0707bf1f215346e488dd1e1dc28b232 100644 (file)
@@ -1195,6 +1195,10 @@ static int tps6598x_apply_patch(struct tps6598x *tps)
 
 release_fw:
        release_firmware(fw);
+       if (ret) {
+               dev_err(tps->dev, "Failed to write patch %s of %zu bytes\n",
+                       firmware_name, fw->size);
+       }
 
        return ret;
 };