]> www.infradead.org Git - users/hch/misc.git/commitdiff
xe: populate buffers before exporting them.
authorDave Airlie <airlied@redhat.com>
Thu, 4 Sep 2025 02:16:42 +0000 (12:16 +1000)
committerDave Airlie <airlied@redhat.com>
Thu, 11 Sep 2025 00:04:58 +0000 (10:04 +1000)
Before exporting a buffer, make sure it has been populated with
pages at least once.

While discussing cgroups we noticed a problem where you could export
a BO to a dma-buf without having it ever being backed or accounted for.

This meant in low memory situations or eventually with cgroups, a
lower privledged process might cause the compositor to try and allocate
a lot of memory on it's behalf and this could fail. At least make
sure the exporter has managed to allocate the RAM at least once
before exporting the object.

This only applies currently to TTM_PL_SYSTEM objects, because
GTT objects get populated on first validate, and VRAM doesn't
use TT.

Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Link: https://lore.kernel.org/r/20250904021643.2050497-4-airlied@gmail.com
drivers/gpu/drm/xe/xe_dma_buf.c

index 346f857f38374f95b337e0fcc0a5e0d603072713..71b70e17bddd7492aea48a60e8cc4d083ae37d02 100644 (file)
@@ -191,10 +191,22 @@ struct dma_buf *xe_gem_prime_export(struct drm_gem_object *obj, int flags)
 {
        struct xe_bo *bo = gem_to_xe_bo(obj);
        struct dma_buf *buf;
+       struct ttm_operation_ctx ctx = {
+               .interruptible = true,
+               .no_wait_gpu = true,
+               /* We opt to avoid OOM on system pages allocations */
+               .gfp_retry_mayfail = true,
+               .allow_res_evict = false,
+       };
+       int ret;
 
        if (bo->vm)
                return ERR_PTR(-EPERM);
 
+       ret = ttm_bo_setup_export(&bo->ttm, &ctx);
+       if (ret)
+               return ERR_PTR(ret);
+
        buf = drm_gem_prime_export(obj, flags);
        if (!IS_ERR(buf))
                buf->ops = &xe_dmabuf_ops;