]> www.infradead.org Git - users/hch/misc.git/commitdiff
net/mlx5e: Remove unused 'xsk' param of mlx5e_build_xdpsq_param
authorCosmin Ratiu <cratiu@nvidia.com>
Tue, 16 Sep 2025 14:11:37 +0000 (17:11 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 18 Sep 2025 01:30:28 +0000 (18:30 -0700)
This was added in commit [1], but its only use removed in commit [2].
The parameter is unused, so remove it from the function parameter list.

[1] commit 9ded70fa1d81 ("net/mlx5e: Don't prefill WQEs in XDP SQ in the
multi buffer mode")
[2] commit 1a9304859b3a ("net/mlx5: XDP, Enable TX side XDP multi-buffer
support")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en/params.c
drivers/net/ethernet/mellanox/mlx5/core/en/params.h
drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c

index 3cca06a74cf9441ea3544198184c2e23df22ede5..31e7f59bc19b1eaeae26e9fdf17a61f3ed1990ec 100644 (file)
@@ -1229,7 +1229,6 @@ static void mlx5e_build_async_icosq_param(struct mlx5_core_dev *mdev,
 
 void mlx5e_build_xdpsq_param(struct mlx5_core_dev *mdev,
                             struct mlx5e_params *params,
-                            struct mlx5e_xsk_param *xsk,
                             struct mlx5e_sq_param *param)
 {
        void *sqc = param->sqc;
@@ -1256,7 +1255,7 @@ int mlx5e_build_channel_param(struct mlx5_core_dev *mdev,
        async_icosq_log_wq_sz = mlx5e_build_async_icosq_log_wq_sz(mdev);
 
        mlx5e_build_sq_param(mdev, params, &cparam->txq_sq);
-       mlx5e_build_xdpsq_param(mdev, params, NULL, &cparam->xdp_sq);
+       mlx5e_build_xdpsq_param(mdev, params, &cparam->xdp_sq);
        mlx5e_build_icosq_param(mdev, icosq_log_wq_sz, &cparam->icosq);
        mlx5e_build_async_icosq_param(mdev, async_icosq_log_wq_sz, &cparam->async_icosq);
 
index 488ccdbc1e2c382015e4f3024494db7b80478287..e3edf79dde5f779ccfed257396d016a846472be7 100644 (file)
@@ -132,7 +132,6 @@ void mlx5e_build_tx_cq_param(struct mlx5_core_dev *mdev,
                             struct mlx5e_cq_param *param);
 void mlx5e_build_xdpsq_param(struct mlx5_core_dev *mdev,
                             struct mlx5e_params *params,
-                            struct mlx5e_xsk_param *xsk,
                             struct mlx5e_sq_param *param);
 int mlx5e_build_channel_param(struct mlx5_core_dev *mdev,
                              struct mlx5e_params *params,
index d743e823362ae89ff2f4eee9eff872aa6800481f..dbd88eb5c082a54a31496b395c4f494b5176d7ba 100644 (file)
@@ -54,7 +54,7 @@ static void mlx5e_build_xsk_cparam(struct mlx5_core_dev *mdev,
                                   struct mlx5e_channel_param *cparam)
 {
        mlx5e_build_rq_param(mdev, params, xsk, &cparam->rq);
-       mlx5e_build_xdpsq_param(mdev, params, xsk, &cparam->xdp_sq);
+       mlx5e_build_xdpsq_param(mdev, params, &cparam->xdp_sq);
 }
 
 static int mlx5e_init_xsk_rq(struct mlx5e_channel *c,