]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
watchdog: da9063: Remove __maybe_unused notations
authorFabio Estevam <festevam@denx.de>
Fri, 18 Oct 2024 13:58:21 +0000 (10:58 -0300)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Tue, 5 Nov 2024 09:04:40 +0000 (10:04 +0100)
Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to
handle the .suspend/.resume callbacks.

These macros allow the suspend and resume functions to be automatically
dropped by the compiler when CONFIG_SUSPEND is disabled, without having
to use __maybe_unused notation.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20241018135821.274376-2-festevam@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/da9063_wdt.c

index 69f884cf1a7bcfa3335c3b2b867626f43e8d87a6..92e1b78ff48107df16373990a77713c83bd93cd1 100644 (file)
@@ -263,7 +263,7 @@ static int da9063_wdt_probe(struct platform_device *pdev)
        return devm_watchdog_register_device(dev, wdd);
 }
 
-static int __maybe_unused da9063_wdt_suspend(struct device *dev)
+static int da9063_wdt_suspend(struct device *dev)
 {
        struct watchdog_device *wdd = dev_get_drvdata(dev);
        struct da9063 *da9063 = watchdog_get_drvdata(wdd);
@@ -277,7 +277,7 @@ static int __maybe_unused da9063_wdt_suspend(struct device *dev)
        return 0;
 }
 
-static int __maybe_unused da9063_wdt_resume(struct device *dev)
+static int da9063_wdt_resume(struct device *dev)
 {
        struct watchdog_device *wdd = dev_get_drvdata(dev);
        struct da9063 *da9063 = watchdog_get_drvdata(wdd);
@@ -291,14 +291,14 @@ static int __maybe_unused da9063_wdt_resume(struct device *dev)
        return 0;
 }
 
-static SIMPLE_DEV_PM_OPS(da9063_wdt_pm_ops,
-                       da9063_wdt_suspend, da9063_wdt_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(da9063_wdt_pm_ops, da9063_wdt_suspend,
+                               da9063_wdt_resume);
 
 static struct platform_driver da9063_wdt_driver = {
        .probe = da9063_wdt_probe,
        .driver = {
                .name = DA9063_DRVNAME_WATCHDOG,
-               .pm = &da9063_wdt_pm_ops,
+               .pm = pm_sleep_ptr(&da9063_wdt_pm_ops),
        },
 };
 module_platform_driver(da9063_wdt_driver);