]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net/mlx5e: SHAMPO, Add no-split ethtool counters for header/data split
authorDragos Tatulea <dtatulea@nvidia.com>
Wed, 11 Sep 2024 20:17:56 +0000 (13:17 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Sep 2024 03:50:30 +0000 (20:50 -0700)
When SHAMPO can't identify the protocol/header of a packet, it will
yield a packet that is not split - all the packet is in the data part.
Count this value in packets and bytes.

Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20240911201757.1505453-15-saeed@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Documentation/networking/device_drivers/ethernet/mellanox/mlx5/counters.rst
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
drivers/net/ethernet/mellanox/mlx5/core/en_stats.h

index 3bd72577af9ae1d51b2b9df46fb6bf663820ec86..99d95be4d159feb1dee7bdcdf112d49c96790aff 100644 (file)
@@ -218,6 +218,22 @@ the software port.
        [#accel]_.
      - Informative
 
+   * - `rx[i]_hds_nosplit_packets`
+     - Number of packets that were not split in header/data split mode. A
+       packet will not get split when the hardware does not support its
+       protocol splitting. An example such a protocol is ICMPv4/v6. Currently
+       TCP and UDP with IPv4/IPv6 are supported for header/data split
+       [#accel]_.
+     - Informative
+
+   * - `rx[i]_hds_nosplit_bytes`
+     - Number of bytes for packets that were not split in header/data split
+       mode. A packet will not get split when the hardware does not support its
+       protocol splitting. An example such a protocol is ICMPv4/v6. Currently
+       TCP and UDP with IPv4/IPv6 are supported for header/data split
+       [#accel]_.
+     - Informative
+
    * - `rx[i]_lro_packets`
      - The number of LRO packets received on ring i [#accel]_.
      - Acceleration
index de9d01036c2807afea326a90955aa3f59d039cbb..8e24ba96c779ae7fbdb8fa8b1a16f3148884a61b 100644 (file)
@@ -2346,6 +2346,9 @@ static void mlx5e_handle_rx_cqe_mpwrq_shampo(struct mlx5e_rq *rq, struct mlx5_cq
                        stats->hds_nodata_packets++;
                        stats->hds_nodata_bytes += head_size;
                }
+       } else {
+               stats->hds_nosplit_packets++;
+               stats->hds_nosplit_bytes += data_bcnt;
        }
 
        mlx5e_shampo_complete_rx_cqe(rq, cqe, cqe_bcnt, *skb);
index e7a3290a708a57fa636a011d2e5d9bb16d22fa76..611ec4b6f3709286a98c5dc36e751d20bda52ec2 100644 (file)
@@ -144,6 +144,8 @@ static const struct counter_desc sw_stats_desc[] = {
        { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_gro_large_hds) },
        { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nodata_packets) },
        { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nodata_bytes) },
+       { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nosplit_packets) },
+       { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_hds_nosplit_bytes) },
        { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_ecn_mark) },
        { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_removed_vlan_packets) },
        { MLX5E_DECLARE_STAT(struct mlx5e_sw_stats, rx_csum_unnecessary) },
@@ -347,6 +349,8 @@ static void mlx5e_stats_grp_sw_update_stats_rq_stats(struct mlx5e_sw_stats *s,
        s->rx_gro_large_hds           += rq_stats->gro_large_hds;
        s->rx_hds_nodata_packets      += rq_stats->hds_nodata_packets;
        s->rx_hds_nodata_bytes        += rq_stats->hds_nodata_bytes;
+       s->rx_hds_nosplit_packets     += rq_stats->hds_nosplit_packets;
+       s->rx_hds_nosplit_bytes       += rq_stats->hds_nosplit_bytes;
        s->rx_ecn_mark                += rq_stats->ecn_mark;
        s->rx_removed_vlan_packets    += rq_stats->removed_vlan_packets;
        s->rx_csum_none               += rq_stats->csum_none;
@@ -2062,6 +2066,8 @@ static const struct counter_desc rq_stats_desc[] = {
        { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, gro_large_hds) },
        { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nodata_packets) },
        { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nodata_bytes) },
+       { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nosplit_packets) },
+       { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, hds_nosplit_bytes) },
        { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, ecn_mark) },
        { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, removed_vlan_packets) },
        { MLX5E_DECLARE_RX_STAT(struct mlx5e_rq_stats, wqe_err) },
index 4c5858c1dd829336080763120328a1c4ce40efda..5961c569cfe01abcd7859c607babb53a427c39b8 100644 (file)
@@ -156,6 +156,8 @@ struct mlx5e_sw_stats {
        u64 rx_gro_large_hds;
        u64 rx_hds_nodata_packets;
        u64 rx_hds_nodata_bytes;
+       u64 rx_hds_nosplit_packets;
+       u64 rx_hds_nosplit_bytes;
        u64 rx_mcast_packets;
        u64 rx_ecn_mark;
        u64 rx_removed_vlan_packets;
@@ -356,6 +358,8 @@ struct mlx5e_rq_stats {
        u64 gro_large_hds;
        u64 hds_nodata_packets;
        u64 hds_nodata_bytes;
+       u64 hds_nosplit_packets;
+       u64 hds_nosplit_bytes;
        u64 mcast_packets;
        u64 ecn_mark;
        u64 removed_vlan_packets;