oracleasm: Classify device connectivity issues as global errors

We used to set the ASM_LOCAL_ERROR qualifier when we got ENOLINK, EBADE
or ENODEV status from the storage stack. The assumption was that the
error could be caused by a pulled cable or a bad switch port and that
other nodes in a cluster might still have access to the storage.

The ASM team would prefer these types of errors to be treated as global,
however, as this would be consistent with database behavior when ASMLIB
is not in the picture.

Remove the ASM_LOCAL_ERROR flag from the device connectivity error code
path.

Orabug: 20117903

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/block/oracleasm/driver.c b/drivers/block/oracleasm/driver.c
index 7eb170784e05fb592d23aa8d65fd2befad4c20ab..94acab23fc914f84d579a5ba1d4bd9b4f02093a8 100644 (file)
--- a/drivers/block/oracleasm/driver.c
+++ b/drivers/block/oracleasm/driver.c
@@ -1067,7 +1067,6 @@ static void asm_end_ioc(struct asm_request *r, unsigned int bytes_done,
                case -EBADE:
                case -ENODEV:
                        r->r_error = ASM_ERR_NODEV;
-                       r->r_status |= ASM_LOCAL_ERROR;
                        break;
 
                case -ENOMEM: