PCI: cpcihp: Remove unused .get_power() and .set_power()
authorGuilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Mon, 17 Feb 2025 18:56:38 +0000 (15:56 -0300)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Sat, 22 Feb 2025 08:03:02 +0000 (08:03 +0000)
The .get_power() and .set_power() function pointers in struct
cpci_hp_controller_ops were declared but never implemented by any
driver.

Thus, to improve code readability and reduce resource usage,
remove these pointers and the code that has never been used.

Link: https://lore.kernel.org/r/20250217185638.398925-1-trintaeoitogc@gmail.com
Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/hotplug/cpci_hotplug.h
drivers/pci/hotplug/cpci_hotplug_core.c

index 03fa39ab0c8846cb8b2152668182d2229aeaeb38..a31d6b62f5235f9b95beeda60ca1d988f166740c 100644 (file)
@@ -44,8 +44,6 @@ struct cpci_hp_controller_ops {
        int (*enable_irq)(void);
        int (*disable_irq)(void);
        int (*check_irq)(void *dev_id);
-       u8  (*get_power)(struct slot *slot);
-       int (*set_power)(struct slot *slot, int value);
 };
 
 struct cpci_hp_controller {
index d0559d2faf50d9b74f171596ca1ab85d36467b5c..dd93e53ea7c258f8e41ba779f3722f086f3e539b 100644 (file)
@@ -71,13 +71,10 @@ static int
 enable_slot(struct hotplug_slot *hotplug_slot)
 {
        struct slot *slot = to_slot(hotplug_slot);
-       int retval = 0;
 
        dbg("%s - physical_slot = %s", __func__, slot_name(slot));
 
-       if (controller->ops->set_power)
-               retval = controller->ops->set_power(slot, 1);
-       return retval;
+       return 0;
 }
 
 static int
@@ -109,12 +106,6 @@ disable_slot(struct hotplug_slot *hotplug_slot)
        }
        cpci_led_on(slot);
 
-       if (controller->ops->set_power) {
-               retval = controller->ops->set_power(slot, 0);
-               if (retval)
-                       goto disable_error;
-       }
-
        slot->adapter_status = 0;
 
        if (slot->extracting) {
@@ -129,11 +120,7 @@ disable_error:
 static u8
 cpci_get_power_status(struct slot *slot)
 {
-       u8 power = 1;
-
-       if (controller->ops->get_power)
-               power = controller->ops->get_power(slot);
-       return power;
+       return 1;
 }
 
 static int