net: phy: marvell: add comment about m88e1111_config_init_1000basex()

The comment in m88e1111_config_init_1000basex() is wrong - it claims
that Autoneg will be enabled, but this doesn't actually happen.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/E1rhos4-003yuQ-5p@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index 1faa22f58366617021010aa339f876160d86c766..42ed013385bfbfba54d75142bb460ff5005f5ec1 100644 (file)
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -919,7 +919,10 @@ static int m88e1111_config_init_1000basex(struct phy_device *phydev)
        if (extsr < 0)
                return extsr;
 
-       /* If using copper mode, ensure 1000BaseX auto-negotiation is enabled */
+       /* If using copper mode, ensure 1000BaseX auto-negotiation is enabled.
+        * FIXME: this does not actually enable 1000BaseX auto-negotiation if
+        * it was previously disabled in the Fiber BMCR!
+        */
        mode = extsr & MII_M1111_HWCFG_MODE_MASK;
        if (mode == MII_M1111_HWCFG_MODE_COPPER_1000X_NOAN) {
                err = phy_modify(phydev, MII_M1111_PHY_EXT_SR,