]> www.infradead.org Git - users/hch/xfsprogs.git/commitdiff
xfs: allow inodes with zero extents but nonzero nblocks
authorDarrick J. Wong <djwong@kernel.org>
Wed, 29 May 2024 04:11:54 +0000 (21:11 -0700)
committerChristoph Hellwig <hch@lst.de>
Mon, 12 Aug 2024 11:53:50 +0000 (13:53 +0200)
Metadata inodes that store btrees will have zero extents and a nonzero
nblocks.  Adjust the inode verifier so that this combination is not
flagged.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
libxfs/xfs_inode_buf.c

index 3732636fdd09d7bff13688668be55d5cfe9ab62d..40421629fa8afd0aa0ac85e6a91db6fdf991a344 100644 (file)
@@ -639,9 +639,6 @@ xfs_dinode_verify(
        if (mode && nextents + naextents > nblocks)
                return __this_address;
 
-       if (nextents + naextents == 0 && nblocks != 0)
-               return __this_address;
-
        if (S_ISDIR(mode) && nextents > mp->m_dir_geo->max_extents)
                return __this_address;
 
@@ -745,6 +742,19 @@ xfs_dinode_verify(
                        return fa;
        }
 
+       /* metadata inodes containing btrees always have zero extent count */
+       if (flags2 & XFS_DIFLAG2_METADATA) {
+               switch (XFS_DFORK_FORMAT(dip, XFS_DATA_FORK)) {
+               case XFS_DINODE_FMT_RMAP:
+                       break;
+               default:
+                       if (nextents + naextents == 0 && nblocks != 0)
+                               return __this_address;
+                       break;
+               }
+       } else if (nextents + naextents == 0 && nblocks != 0)
+               return __this_address;
+
        return NULL;
 }