mtd: Unconditionally update ->fail_addr and ->addr in part_erase()

->fail_addr and ->addr can be updated no matter the result of
parent->_erase(), we just need to remove the code doing the same thing
in mtd_erase_callback() to avoid adjusting those fields twice.

Note that this can be done because all MTD users have been converted to
not pass an erase_info->callback() and are thus only taking the
->addr_fail and ->addr fields into account after part_erase() has
returned.

While we're at it, get rid of the erase_info->mtd field which was only
needed to let mtd_erase_callback() get the partition device back.

Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Richard Weinberger <richard@nod.at>

diff --git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c
index fcf9907e79871e5e5842fa5346d75dbff312c112..0a6adfaec7b595c7197bd2541fee4eabc94e049b 100644 (file)
--- a/drivers/mtd/ftl.c
+++ b/drivers/mtd/ftl.c
@@ -342,7 +342,6 @@ static int erase_xfer(partition_t *part,
     if (!erase)
             return -ENOMEM;
 
-    erase->mtd = part->mbd.mtd;
     erase->addr = xfer->Offset;
     erase->len = 1 << part->header.EraseUnitSize;
 

diff --git a/drivers/mtd/inftlmount.c b/drivers/mtd/inftlmount.c
index 0f47be4834d85bbaab60c905bedf421b0bee3ef1..aab4f68bd36fc71882900274aaf3791cf38d3ab8 100644 (file)
--- a/drivers/mtd/inftlmount.c
+++ b/drivers/mtd/inftlmount.c
@@ -208,8 +208,6 @@ static int find_boot_record(struct INFTLrecord *inftl)
                        if (ip->Reserved0 != ip->firstUnit) {
                                struct erase_info *instr = &inftl->instr;
 
-                               instr->mtd = inftl->mbd.mtd;
-
                                /*
                                 *      Most likely this is using the
                                 *      undocumented qiuck mount feature.
@@ -385,7 +383,6 @@ int INFTL_formatblock(struct INFTLrecord *inftl, int block)
           _first_? */
 
        /* Use async erase interface, test return code */
-       instr->mtd = inftl->mbd.mtd;
        instr->addr = block * inftl->EraseSize;
        instr->len = inftl->mbd.mtd->erasesize;
        /* Erase one physical eraseblock at a time, even though the NAND api

diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index 7b2b7f651181bb559924e85a7deefb3d9783edbb..a5b1933c0490946d3c328f13074865af10718f19 100644 (file)
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -65,7 +65,6 @@ static int erase_write (struct mtd_info *mtd, unsigned long pos,
        /*
         * First, let's erase the flash block.
         */
-       erase.mtd = mtd;
        erase.addr = pos;
        erase.len = len;
 

diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
index 2beb22dd6bbb3ba2ef18ee89cd8c100e76617dee..c06b33f80e751dadbbb26535cb3f3b9539c4bc01 100644 (file)
--- a/drivers/mtd/mtdchar.c
+++ b/drivers/mtd/mtdchar.c
@@ -726,7 +726,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
                                erase->addr = einfo32.start;
                                erase->len = einfo32.length;
                        }
-                       erase->mtd = mtd;
 
                        ret = mtd_erase(mtd, erase);
                        kfree(erase);

diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c
index caa09bf6e57262ab7f156fe3c7703566d29cf2e3..93c47e56d9d8fbeddabffe8defe2e50443d336be 100644 (file)
--- a/drivers/mtd/mtdconcat.c
+++ b/drivers/mtd/mtdconcat.c
@@ -427,7 +427,6 @@ static int concat_erase(struct mtd_info *mtd, struct erase_info *instr)
                        erase->len = length;
 
                length -= erase->len;
-               erase->mtd = subdev;
                if ((err = mtd_erase(subdev, erase))) {
                        /* sanity check: should never happen since
                         * block alignment has been checked above */

diff --git a/drivers/mtd/mtdoops.c b/drivers/mtd/mtdoops.c
index 028ded59297b98a5a9da98b9ff2321498613d784..9f25111fd55934973be421aca4ca63e41dc74da3 100644 (file)
--- a/drivers/mtd/mtdoops.c
+++ b/drivers/mtd/mtdoops.c
@@ -94,7 +94,6 @@ static int mtdoops_erase_block(struct mtdoops_context *cxt, int offset)
        int ret;
        int page;
 
-       erase.mtd = mtd;
        erase.addr = offset;
        erase.len = mtd->erasesize;
 

diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
index ae1206633d9d75a39321986c9e6a508566fb0963..1c07a6f0dfe56aecc07c58326a44e130064efab2 100644 (file)
--- a/drivers/mtd/mtdpart.c
+++ b/drivers/mtd/mtdpart.c
@@ -205,23 +205,15 @@ static int part_erase(struct mtd_info *mtd, struct erase_info *instr)
 
        instr->addr += part->offset;
        ret = part->parent->_erase(part->parent, instr);
-       if (ret) {
-               if (instr->fail_addr != MTD_FAIL_ADDR_UNKNOWN)
-                       instr->fail_addr -= part->offset;
-               instr->addr -= part->offset;
-       }
+       if (instr->fail_addr != MTD_FAIL_ADDR_UNKNOWN)
+               instr->fail_addr -= part->offset;
+       instr->addr -= part->offset;
+
        return ret;
 }
 
 void mtd_erase_callback(struct erase_info *instr)
 {
-       if (instr->mtd->_erase == part_erase) {
-               struct mtd_part *part = mtd_to_part(instr->mtd);
-
-               if (instr->fail_addr != MTD_FAIL_ADDR_UNKNOWN)
-                       instr->fail_addr -= part->offset;
-               instr->addr -= part->offset;
-       }
 }
 EXPORT_SYMBOL_GPL(mtd_erase_callback);
 

diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c
index d390324d102e3f21f67e96ac9703ddc4ef29fd91..7161f8a17f6204b59412eb7a04604993990f58d4 100644 (file)
--- a/drivers/mtd/mtdswap.c
+++ b/drivers/mtd/mtdswap.c
@@ -549,8 +549,6 @@ static int mtdswap_erase_block(struct mtdswap_dev *d, struct swap_eb *eb)
 
 retry:
        memset(&erase, 0, sizeof(struct erase_info));
-
-       erase.mtd       = mtd;
        erase.addr      = mtdswap_eb_offset(d, eb);
        erase.len       = mtd->erasesize;
 

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index e70ca16a5118150bf1e3c3e3ffc33d97a08efe19..16c8bc06975dceb1af34fc191af5f4d6e5b42284 100644 (file)
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -527,7 +527,6 @@ static int nand_block_markbad_lowlevel(struct mtd_info *mtd, loff_t ofs)
 
                /* Attempt erase before marking OOB */
                memset(&einfo, 0, sizeof(einfo));
-               einfo.mtd = mtd;
                einfo.addr = ofs;
                einfo.len = 1ULL << chip->phys_erase_shift;
                nand_erase_nand(mtd, &einfo, 0);

diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c
index 36092850be2c10b1e54c5dbf3d7d92e4b6ae54ed..d9f4ceff25682f98e4143912ad80b1d6dfdb42a2 100644 (file)
--- a/drivers/mtd/nand/nand_bbt.c
+++ b/drivers/mtd/nand/nand_bbt.c
@@ -852,7 +852,6 @@ static int write_bbt(struct mtd_info *mtd, uint8_t *buf,
                }
 
                memset(&einfo, 0, sizeof(einfo));
-               einfo.mtd = mtd;
                einfo.addr = to;
                einfo.len = 1 << this->bbt_erase_shift;
                res = nand_erase_nand(mtd, &einfo, 1);

diff --git a/drivers/mtd/nftlmount.c b/drivers/mtd/nftlmount.c
index 07e122449759ac37277bf947593e83680b0efe36..d8f6dba01c8747ece0a238a5a764d52f5bc55320 100644 (file)
--- a/drivers/mtd/nftlmount.c
+++ b/drivers/mtd/nftlmount.c
@@ -328,7 +328,6 @@ int NFTL_formatblock(struct NFTLrecord *nftl, int block)
        memset(instr, 0, sizeof(struct erase_info));
 
        /* XXX: use async erase interface, XXX: test return code */
-       instr->mtd = nftl->mbd.mtd;
        instr->addr = block * nftl->EraseSize;
        instr->len = nftl->EraseSize;
        if (mtd_erase(mtd, instr)) {

diff --git a/drivers/mtd/rfd_ftl.c b/drivers/mtd/rfd_ftl.c
index 4e0b55cd08e250512c0fa57b7014d3b6fbbd2818..df27f24ce0fa7ce5c2ee65eb9f83da28bd8b9b56 100644 (file)
--- a/drivers/mtd/rfd_ftl.c
+++ b/drivers/mtd/rfd_ftl.c
@@ -275,7 +275,6 @@ static int erase_block(struct partition *part, int block)
        if (!erase)
                return -ENOMEM;
 
-       erase->mtd = part->mbd.mtd;
        erase->addr = part->blocks[block].offset;
        erase->len = part->block_size;
 

diff --git a/drivers/mtd/sm_ftl.c b/drivers/mtd/sm_ftl.c
index c11156f9d96f1c592b2f58bfbaa75886898f2fb7..72740ede9f05d61d6b5889c95bbcfc8737e98fe1 100644 (file)
--- a/drivers/mtd/sm_ftl.c
+++ b/drivers/mtd/sm_ftl.c
@@ -460,7 +460,6 @@ static int sm_erase_block(struct sm_ftl *ftl, int zone_num, uint16_t block,
        struct mtd_info *mtd = ftl->trans->mtd;
        struct erase_info erase;
 
-       erase.mtd = mtd;
        erase.addr = sm_mkoffset(ftl, zone_num, block, 0);
        erase.len = ftl->block_size;
 

diff --git a/drivers/mtd/tests/mtd_test.c b/drivers/mtd/tests/mtd_test.c
index 0ac625e8f798864855c7d7c2ca6ae30536badb54..c84250beffdc910136c8964a7f3c002aa1215edd 100644 (file)
--- a/drivers/mtd/tests/mtd_test.c
+++ b/drivers/mtd/tests/mtd_test.c
@@ -14,7 +14,6 @@ int mtdtest_erase_eraseblock(struct mtd_info *mtd, unsigned int ebnum)
        loff_t addr = (loff_t)ebnum * mtd->erasesize;
 
        memset(&ei, 0, sizeof(struct erase_info));
-       ei.mtd  = mtd;
        ei.addr = addr;
        ei.len  = mtd->erasesize;
 

diff --git a/drivers/mtd/tests/speedtest.c b/drivers/mtd/tests/speedtest.c
index f8e5dc11f9438c75b181d9083c01a97727359486..20edb3b49c77e176994797218587ece4f04c03ef 100644 (file)
--- a/drivers/mtd/tests/speedtest.c
+++ b/drivers/mtd/tests/speedtest.c
@@ -59,7 +59,6 @@ static int multiblock_erase(int ebnum, int blocks)
        loff_t addr = (loff_t)ebnum * mtd->erasesize;
 
        memset(&ei, 0, sizeof(struct erase_info));
-       ei.mtd  = mtd;
        ei.addr = addr;
        ei.len  = mtd->erasesize * blocks;
 

diff --git a/drivers/mtd/ubi/io.c b/drivers/mtd/ubi/io.c
index 8843d26837b210e7c19746e9aac4192f688bcff7..0e3a76a9e2f8b4533377bc3023186d5a8d53a7e7 100644 (file)
--- a/drivers/mtd/ubi/io.c
+++ b/drivers/mtd/ubi/io.c
@@ -333,7 +333,6 @@ static int do_sync_erase(struct ubi_device *ubi, int pnum)
 retry:
        memset(&ei, 0, sizeof(struct erase_info));
 
-       ei.mtd      = ubi->mtd;
        ei.addr     = (loff_t)pnum * ubi->peb_size;
        ei.len      = ubi->peb_size;
 

diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
index 09bb6c00b86905c1ae12cc2d7da5ecea8be39ea6..83b8f06b4a642f3917b7720a2acd687854927ca3 100644 (file)
--- a/fs/jffs2/erase.c
+++ b/fs/jffs2/erase.c
@@ -59,7 +59,6 @@ static void jffs2_erase_block(struct jffs2_sb_info *c,
 
        memset(instr, 0, sizeof(*instr));
 
-       instr->mtd = c->mtd;
        instr->addr = jeb->offset;
        instr->len = c->sector_size;
 

diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 5018437d79997cb497f004b5e9ccf4b2c6c89ad0..4cbb7f5552448717cb78a66dafbb83b31ab24b9c 100644 (file)
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -38,13 +38,14 @@
 
 #define MTD_FAIL_ADDR_UNKNOWN -1LL
 
+struct mtd_info;
+
 /*
  * If the erase fails, fail_addr might indicate exactly which block failed. If
  * fail_addr = MTD_FAIL_ADDR_UNKNOWN, the failure was not at the device level
  * or was not specific to any particular block.
  */
 struct erase_info {
-       struct mtd_info *mtd;
        uint64_t addr;
        uint64_t len;
        uint64_t fail_addr;