]> www.infradead.org Git - users/hch/misc.git/commitdiff
docs: kdoc: add a couple more comments in create_parameter_list()
authorJonathan Corbet <corbet@lwn.net>
Thu, 14 Aug 2025 15:40:32 +0000 (09:40 -0600)
committerJonathan Corbet <corbet@lwn.net>
Mon, 18 Aug 2025 16:19:19 +0000 (10:19 -0600)
Make what the final code is doing a bit more clear to slow readers like me.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Link: https://lore.kernel.org/r/20250814154035.328769-5-corbet@lwn.net
scripts/lib/kdoc/kdoc_parser.py

index 07234ce04409ad36d45459904f752ecd585400bd..29881757bf1c9fcde8758ef76223d07305d67b6c 100644 (file)
@@ -568,12 +568,18 @@ class KernelDoc:
 
                 bitfield_re = KernRe(r'(.*?):(\w+)')
                 for param in args:
+                    #
+                    # For pointers, shift the star(s) from the variable name to the
+                    # type declaration.
+                    #
                     r = KernRe(r'^(\*+)\s*(.*)')
                     if r.match(param):
                         self.push_parameter(ln, decl_type, r.group(2),
                                             f"{dtype} {r.group(1)}",
                                             arg, declaration_name)
-
+                    #
+                    # Perform a similar shift for bitfields.
+                    #
                     elif bitfield_re.search(param):
                         if dtype != "":  # Skip unnamed bit-fields
                             self.push_parameter(ln, decl_type, bitfield_re.group(1),