]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
cxl/core: Fix incorrect vendor debug UUID define
authorpeng guo <engguopeng@buaa.edu.cn>
Wed, 10 Jul 2024 02:31:12 +0000 (10:31 +0800)
committerDave Jiang <dave.jiang@intel.com>
Wed, 10 Jul 2024 23:10:36 +0000 (16:10 -0700)
When user send a mbox command whose opcode is CXL_MBOX_OP_CLEAR_LOG and
the in_payload is normal vendor debug log UUID according to
the CXL specification cxl_payload_from_user_allowed() will return
false unexpectedly, Sending mbox cmd operation fails and the kernel
log will print:
Clear Log: input payload not allowed.

All CXL devices that support a debug log shall support the Vendor Debug
Log to allow the log to be accessed through a common host driver, for any
device, all versions of the CXL specification define the same value with
Log Identifier of: 5e1819d9-11a9-400c-811f-d60719403d86

Refer to CXL spec r3.1 Table 8-71

Fix the definition value of DEFINE_CXL_VENDOR_DEBUG_UUID to match the
CXL specification.

Fixes: 472b1ce6e9d6 ("cxl/mem: Enable commands via CEL")
Signed-off-by: peng guo <engguopeng@buaa.edu.cn>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Link: https://patch.msgid.link/20240710023112.8063-1-engguopeng@buaa.edu.cn
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
drivers/cxl/cxlmem.h

index 19aba81cdf13208d525a8b28443007b979b1adbb..f55141c6d64ef74578909d0b47986094f3b47d95 100644 (file)
@@ -562,7 +562,7 @@ enum cxl_opcode {
                  0x3b, 0x3f, 0x17)
 
 #define DEFINE_CXL_VENDOR_DEBUG_UUID                                           \
-       UUID_INIT(0xe1819d9, 0x11a9, 0x400c, 0x81, 0x1f, 0xd6, 0x07, 0x19,     \
+       UUID_INIT(0x5e1819d9, 0x11a9, 0x400c, 0x81, 0x1f, 0xd6, 0x07, 0x19,     \
                  0x40, 0x3d, 0x86)
 
 struct cxl_mbox_get_supported_logs {