bpf: Fix overloading of MEM_UNINIT's meaning

Lonial reported an issue in the BPF verifier where check_mem_size_reg()
has the following code:

    if (!tnum_is_const(reg->var_off))
        /* For unprivileged variable accesses, disable raw
         * mode so that the program is required to
         * initialize all the memory that the helper could
         * just partially fill up.
         */
         meta = NULL;

This means that writes are not checked when the register containing the
size of the passed buffer has not a fixed size. Through this bug, a BPF
program can write to a map which is marked as read-only, for example,
.rodata global maps.

The problem is that MEM_UNINIT's initial meaning that "the passed buffer
to the BPF helper does not need to be initialized" which was added back
in commit 435faee1aae9 ("bpf, verifier: add ARG_PTR_TO_RAW_STACK type")
got overloaded over time with "the passed buffer is being written to".

The problem however is that checks such as the above which were added later
via 06c1c049721a ("bpf: allow helpers access to variable memory") set meta
to NULL in order force the user to always initialize the passed buffer to
the helper. Due to the current double meaning of MEM_UNINIT, this bypasses
verifier write checks to the memory (not boundary checks though) and only
assumes the latter memory is read instead.

Fix this by reverting MEM_UNINIT back to its original meaning, and having
MEM_WRITE as an annotation to BPF helpers in order to then trigger the
BPF verifier checks for writing to memory.

Some notes: check_arg_pair_ok() ensures that for ARG_CONST_SIZE{,_OR_ZERO}
we can access fn->arg_type[arg - 1] since it must contain a preceding
ARG_PTR_TO_MEM. For check_mem_reg() the meta argument can be removed
altogether since we do check both BPF_READ and BPF_WRITE. Same for the
equivalent check_kfunc_mem_size_reg().

Fixes: 7b3552d3f9f6 ("bpf: Reject writes for PTR_TO_MAP_KEY in check_helper_mem_access")
Fixes: 97e6d7dab1ca ("bpf: Check PTR_TO_MEM | MEM_RDONLY in check_helper_mem_access")
Fixes: 15baa55ff5b0 ("bpf/verifier: allow all functions to read user provided context")
Reported-by: Lonial Con <kongln9170@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20241021152809.33343-2-daniel@iogearbox.net
Signed-off-by: Alexei Starovoitov <ast@kernel.org>

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 411ab1b57af420fc35296ab0941e8df6c324a220..f9e2f1cd49750e19a30f19a5dd190a1ec4f37df4 100644 (file)
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -7438,7 +7438,8 @@ mark:
 }
 
 static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
-                                  int access_size, bool zero_size_allowed,
+                                  int access_size, enum bpf_access_type access_type,
+                                  bool zero_size_allowed,
                                   struct bpf_call_arg_meta *meta)
 {
        struct bpf_reg_state *regs = cur_regs(env), *reg = &regs[regno];
@@ -7450,7 +7451,7 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
                return check_packet_access(env, regno, reg->off, access_size,
                                           zero_size_allowed);
        case PTR_TO_MAP_KEY:
-               if (meta && meta->raw_mode) {
+               if (access_type == BPF_WRITE) {
                        verbose(env, "R%d cannot write into %s\n", regno,
                                reg_type_str(env, reg->type));
                        return -EACCES;
@@ -7458,15 +7459,13 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
                return check_mem_region_access(env, regno, reg->off, access_size,
                                               reg->map_ptr->key_size, false);
        case PTR_TO_MAP_VALUE:
-               if (check_map_access_type(env, regno, reg->off, access_size,
-                                         meta && meta->raw_mode ? BPF_WRITE :
-                                         BPF_READ))
+               if (check_map_access_type(env, regno, reg->off, access_size, access_type))
                        return -EACCES;
                return check_map_access(env, regno, reg->off, access_size,
                                        zero_size_allowed, ACCESS_HELPER);
        case PTR_TO_MEM:
                if (type_is_rdonly_mem(reg->type)) {
-                       if (meta && meta->raw_mode) {
+                       if (access_type == BPF_WRITE) {
                                verbose(env, "R%d cannot write into %s\n", regno,
                                        reg_type_str(env, reg->type));
                                return -EACCES;
@@ -7477,7 +7476,7 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
                                               zero_size_allowed);
        case PTR_TO_BUF:
                if (type_is_rdonly_mem(reg->type)) {
-                       if (meta && meta->raw_mode) {
+                       if (access_type == BPF_WRITE) {
                                verbose(env, "R%d cannot write into %s\n", regno,
                                        reg_type_str(env, reg->type));
                                return -EACCES;
@@ -7505,7 +7504,6 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
                 * Dynamically check it now.
                 */
                if (!env->ops->convert_ctx_access) {
-                       enum bpf_access_type atype = meta && meta->raw_mode ? BPF_WRITE : BPF_READ;
                        int offset = access_size - 1;
 
                        /* Allow zero-byte read from PTR_TO_CTX */
@@ -7513,7 +7511,7 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
                                return zero_size_allowed ? 0 : -EACCES;
 
                        return check_mem_access(env, env->insn_idx, regno, offset, BPF_B,
-                                               atype, -1, false, false);
+                                               access_type, -1, false, false);
                }
 
                fallthrough;
@@ -7538,6 +7536,7 @@ static int check_helper_mem_access(struct bpf_verifier_env *env, int regno,
  */
 static int check_mem_size_reg(struct bpf_verifier_env *env,
                              struct bpf_reg_state *reg, u32 regno,
+                             enum bpf_access_type access_type,
                              bool zero_size_allowed,
                              struct bpf_call_arg_meta *meta)
 {
@@ -7553,15 +7552,12 @@ static int check_mem_size_reg(struct bpf_verifier_env *env,
         */
        meta->msize_max_value = reg->umax_value;
 
-       /* The register is SCALAR_VALUE; the access check
-        * happens using its boundaries.
+       /* The register is SCALAR_VALUE; the access check happens using
+        * its boundaries. For unprivileged variable accesses, disable
+        * raw mode so that the program is required to initialize all
+        * the memory that the helper could just partially fill up.
         */
        if (!tnum_is_const(reg->var_off))
-               /* For unprivileged variable accesses, disable raw
-                * mode so that the program is required to
-                * initialize all the memory that the helper could
-                * just partially fill up.
-                */
                meta = NULL;
 
        if (reg->smin_value < 0) {
@@ -7581,9 +7577,8 @@ static int check_mem_size_reg(struct bpf_verifier_env *env,
                        regno);
                return -EACCES;
        }
-       err = check_helper_mem_access(env, regno - 1,
-                                     reg->umax_value,
-                                     zero_size_allowed, meta);
+       err = check_helper_mem_access(env, regno - 1, reg->umax_value,
+                                     access_type, zero_size_allowed, meta);
        if (!err)
                err = mark_chain_precision(env, regno);
        return err;
@@ -7594,13 +7589,11 @@ static int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg
 {
        bool may_be_null = type_may_be_null(reg->type);
        struct bpf_reg_state saved_reg;
-       struct bpf_call_arg_meta meta;
        int err;
 
        if (register_is_null(reg))
                return 0;
 
-       memset(&meta, 0, sizeof(meta));
        /* Assuming that the register contains a value check if the memory
         * access is safe. Temporarily save and restore the register's state as
         * the conversion shouldn't be visible to a caller.
@@ -7610,10 +7603,8 @@ static int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg
                mark_ptr_not_null_reg(reg);
        }
 
-       err = check_helper_mem_access(env, regno, mem_size, true, &meta);
-       /* Check access for BPF_WRITE */
-       meta.raw_mode = true;
-       err = err ?: check_helper_mem_access(env, regno, mem_size, true, &meta);
+       err = check_helper_mem_access(env, regno, mem_size, BPF_READ, true, NULL);
+       err = err ?: check_helper_mem_access(env, regno, mem_size, BPF_WRITE, true, NULL);
 
        if (may_be_null)
                *reg = saved_reg;
@@ -7639,13 +7630,12 @@ static int check_kfunc_mem_size_reg(struct bpf_verifier_env *env, struct bpf_reg
                mark_ptr_not_null_reg(mem_reg);
        }
 
-       err = check_mem_size_reg(env, reg, regno, true, &meta);
-       /* Check access for BPF_WRITE */
-       meta.raw_mode = true;
-       err = err ?: check_mem_size_reg(env, reg, regno, true, &meta);
+       err = check_mem_size_reg(env, reg, regno, BPF_READ, true, &meta);
+       err = err ?: check_mem_size_reg(env, reg, regno, BPF_WRITE, true, &meta);
 
        if (may_be_null)
                *mem_reg = saved_reg;
+
        return err;
 }
 
@@ -8948,9 +8938,8 @@ skip_type_check:
                        verbose(env, "invalid map_ptr to access map->key\n");
                        return -EACCES;
                }
-               err = check_helper_mem_access(env, regno,
-                                             meta->map_ptr->key_size, false,
-                                             NULL);
+               err = check_helper_mem_access(env, regno, meta->map_ptr->key_size,
+                                             BPF_READ, false, NULL);
                break;
        case ARG_PTR_TO_MAP_VALUE:
                if (type_may_be_null(arg_type) && register_is_null(reg))
@@ -8965,9 +8954,9 @@ skip_type_check:
                        return -EACCES;
                }
                meta->raw_mode = arg_type & MEM_UNINIT;
-               err = check_helper_mem_access(env, regno,
-                                             meta->map_ptr->value_size, false,
-                                             meta);
+               err = check_helper_mem_access(env, regno, meta->map_ptr->value_size,
+                                             arg_type & MEM_WRITE ? BPF_WRITE : BPF_READ,
+                                             false, meta);
                break;
        case ARG_PTR_TO_PERCPU_BTF_ID:
                if (!reg->btf_id) {
@@ -9009,7 +8998,9 @@ skip_type_check:
                 */
                meta->raw_mode = arg_type & MEM_UNINIT;
                if (arg_type & MEM_FIXED_SIZE) {
-                       err = check_helper_mem_access(env, regno, fn->arg_size[arg], false, meta);
+                       err = check_helper_mem_access(env, regno, fn->arg_size[arg],
+                                                     arg_type & MEM_WRITE ? BPF_WRITE : BPF_READ,
+                                                     false, meta);
                        if (err)
                                return err;
                        if (arg_type & MEM_ALIGNED)
@@ -9017,10 +9008,16 @@ skip_type_check:
                }
                break;
        case ARG_CONST_SIZE:
-               err = check_mem_size_reg(env, reg, regno, false, meta);
+               err = check_mem_size_reg(env, reg, regno,
+                                        fn->arg_type[arg - 1] & MEM_WRITE ?
+                                        BPF_WRITE : BPF_READ,
+                                        false, meta);
                break;
        case ARG_CONST_SIZE_OR_ZERO:
-               err = check_mem_size_reg(env, reg, regno, true, meta);
+               err = check_mem_size_reg(env, reg, regno,
+                                        fn->arg_type[arg - 1] & MEM_WRITE ?
+                                        BPF_WRITE : BPF_READ,
+                                        true, meta);
                break;
        case ARG_PTR_TO_DYNPTR:
                err = process_dynptr_func(env, regno, insn_idx, arg_type, 0);