drm/msm: Stop dropping struct_mutex in recover_worker()

Now that we don't have the mmap_sem lock inversion, we don't need to
jump through this particular hoop anymore.

Signed-off-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>

diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index 2b76657badd5765ecfd15754580119e74389b8b3..bf4ee2766431ef8f1b07bf53bcfac5659dc2784e 100644 (file)
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -450,21 +450,8 @@ static void recover_worker(struct work_struct *work)
                task = get_pid_task(submit->pid, PIDTYPE_PID);
                if (task) {
                        comm = kstrdup(task->comm, GFP_KERNEL);
-
-                       /*
-                        * So slightly annoying, in other paths like
-                        * mmap'ing gem buffers, mmap_sem is acquired
-                        * before struct_mutex, which means we can't
-                        * hold struct_mutex across the call to
-                        * get_cmdline().  But submits are retired
-                        * from the same in-order workqueue, so we can
-                        * safely drop the lock here without worrying
-                        * about the submit going away.
-                        */
-                       mutex_unlock(&dev->struct_mutex);
                        cmd = kstrdup_quotable_cmdline(task, GFP_KERNEL);
                        put_task_struct(task);
-                       mutex_lock(&dev->struct_mutex);
                }
 
                if (comm && cmd) {