]> www.infradead.org Git - users/hch/misc.git/commitdiff
net/mlx5e: Do not fail PSP init on missing caps
authorCosmin Ratiu <cratiu@nvidia.com>
Sun, 5 Oct 2025 08:29:59 +0000 (11:29 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 7 Oct 2025 10:59:56 +0000 (12:59 +0200)
PSP support requires a set of cap bits to be set, otherwise an init
error is logged.

But logging an error when PSP cannot be initialized is too much, and not
in line with other features. If a feature cannot be initialized because
it is not supported, that's not an error. An error should only be
printed when the feature cannot be initialized because of an actual
error.

Fixes: 89ee2d92f66c ("net/mlx5e: Support PSP offload functionality")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1759652999-858513-4-git-send-email-tariqt@nvidia.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c

index b4cb131c5f811eda2b38e37a38f7c42e47cbe61d..8565cfe8d7dce8706f021007ee7fb61488c016cf 100644 (file)
@@ -893,27 +893,27 @@ int mlx5e_psp_init(struct mlx5e_priv *priv)
 
        if (!mlx5_is_psp_device(mdev)) {
                mlx5_core_dbg(mdev, "PSP offload not supported\n");
-               return -EOPNOTSUPP;
+               return 0;
        }
 
        if (!MLX5_CAP_ETH(mdev, swp)) {
                mlx5_core_dbg(mdev, "SWP not supported\n");
-               return -EOPNOTSUPP;
+               return 0;
        }
 
        if (!MLX5_CAP_ETH(mdev, swp_csum)) {
                mlx5_core_dbg(mdev, "SWP checksum not supported\n");
-               return -EOPNOTSUPP;
+               return 0;
        }
 
        if (!MLX5_CAP_ETH(mdev, swp_csum_l4_partial)) {
                mlx5_core_dbg(mdev, "SWP L4 partial checksum not supported\n");
-               return -EOPNOTSUPP;
+               return 0;
        }
 
        if (!MLX5_CAP_ETH(mdev, swp_lso)) {
                mlx5_core_dbg(mdev, "PSP LSO not supported\n");
-               return -EOPNOTSUPP;
+               return 0;
        }
 
        psp = kzalloc(sizeof(*psp), GFP_KERNEL);